From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: DJ Delorie <dj@redhat.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH v2 3/3] inet: Return EAI_MEMORY when nrl_domainname() fails to allocate memory
Date: Tue, 8 Mar 2022 12:43:59 -0300 [thread overview]
Message-ID: <a2ba8ace-6e96-b1f4-6601-9acd10847a5c@linaro.org> (raw)
In-Reply-To: <xnk0d55bh1.fsf@greed.delorie.com>
On 08/03/2022 01:12, DJ Delorie wrote:
>
> Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org> writes:
>> -static void
>> +static bool
>
> Ok. Please include comment saying what true/false return means, though.
Will do, thanks for the review.
> LGTM with that one comment added.
>
> Reviewed-by: DJ Delorie <dj@redhat.com>
>
next prev parent reply other threads:[~2022-03-08 15:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-10 11:07 [PATCH v2 0/3] Fixes for getnameinfo() with NI_NOFQDN Adhemerval Zanella
2021-12-10 11:07 ` [PATCH v2 1/3] inet: Fix getnameinfo (NI_NOFQDN) race condition (BZ#28566) Adhemerval Zanella
2022-02-03 20:52 ` Adhemerval Zanella
2022-03-08 3:44 ` DJ Delorie
2021-12-10 11:07 ` [PATCH v2 2/3] inet: Remove strdupa from nrl_domainname() Adhemerval Zanella
2022-02-03 20:52 ` Adhemerval Zanella
2022-03-08 3:53 ` DJ Delorie
2021-12-10 11:07 ` [PATCH v2 3/3] inet: Return EAI_MEMORY when nrl_domainname() fails to allocate memory Adhemerval Zanella
2022-02-03 20:53 ` Adhemerval Zanella
2022-03-08 4:12 ` DJ Delorie
2022-03-08 15:43 ` Adhemerval Zanella [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-11-12 14:21 [PATCH v2 0/3] Fixes for getnameinfo() with NI_NOFQDN Adhemerval Zanella
2021-11-12 14:21 ` [PATCH v2 3/3] inet: Return EAI_MEMORY when nrl_domainname() fails to allocate memory Adhemerval Zanella
2021-11-12 15:44 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2ba8ace-6e96-b1f4-6601-9acd10847a5c@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=dj@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).