From: Paul Eggert <eggert@cs.ucla.edu>
To: GNU C Library <libc-alpha@sourceware.org>
Subject: UTF-8 in glibc commit messages
Date: Tue, 13 Apr 2021 12:21:22 -0700 [thread overview]
Message-ID: <a5c371a5-48ea-1eb4-719a-0861d6797938@cs.ucla.edu> (raw)
Today I tried to install a glibc fix with some non-ASCII chars in the
commit message, but sourceware.org rejected the fix with the diagnostic
reproduced at the end of this email.
I'm puzzled by the message, as I see that existing commit messages use
UTF-8, e.g., 41f013cef24884604c303435dd1915be2ea5c0e0's commit message
contains the phrase "Developer’s Manual" with the same curly apostrophe
that my proposed commit used. Has something changed recently on
sourceware.org to reject such commits?
I assume that UTF-8 is fine in commit messages as we use it to spell
contributors' names. I worked around this particular problem by
ASCIIfying the quotes but I'd rather spell people's names nicely in any
future patches. (It might make sense for the commit hook to rejects some
troublesome Unicode characters but that's a somewhat different topic.)
Here's the diagnostic I got:
$ git push
Enumerating objects: 21, done.
Counting objects: 100% (21/21), done.
Delta compression using up to 4 threads
Compressing objects: 100% (11/11), done.
Writing objects: 100% (11/11), 3.79 KiB | 242.00 KiB/s, done.
Total 11 (delta 10), reused 0 (delta 0), pack-reused 0
remote: *** Invalid revision history for commit
371ef6b43fcb5052444c3f0e1ec09d01c5017149:
remote: *** It contains characters not in the ISO-8859-15 charset.
remote: ***
remote: *** Below is the first line where this was detected (line 16):
remote: *** | Use code font for ‘malloc’ instead of roman font.
remote: *** ^
remote: *** |
remote: ***
remote: *** Please amend the commit's revision history to remove it
remote: *** and try again.
remote: error: hook declined to update refs/heads/master
To sourceware.org:/git/glibc.git
! [remote rejected] master -> master (hook declined)
error: failed to push some refs to 'sourceware.org:/git/glibc.git'
next reply other threads:[~2021-04-13 19:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-13 19:21 Paul Eggert [this message]
2021-04-13 20:19 ` Joseph Myers
2021-04-14 0:06 ` Paul Eggert
2021-04-14 15:01 ` Mike Frysinger
2021-04-14 17:41 ` DJ Delorie
2021-04-14 18:08 ` Paul Eggert
2021-04-14 18:16 ` Adhemerval Zanella
2021-04-14 18:24 ` Paul Eggert
2021-04-14 20:28 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5c371a5-48ea-1eb4-719a-0861d6797938@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).