From: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
To: Florian Weimer <fweimer@redhat.com>, libc-alpha@sourceware.org
Subject: Re: [PATCH] <string.h>: Make strchrnul, strcasestr, memmem available by default
Date: Thu, 8 Dec 2022 14:07:59 -0300 [thread overview]
Message-ID: <a60df5ec-68ea-9d68-b707-2ef05ce2d5cb@linaro.org> (raw)
In-Reply-To: <87h6yo4e3v.fsf@oldenburg.str.redhat.com>
On 24/11/22 11:32, Florian Weimer via Libc-alpha wrote:
> FreeBSD makes them available by default, too, so there does not seem
> to be a reason to restrict these functions to _GNU_SOURCE.
>
> Tested on x86_64-linux-gnu.
LGTM, thanks.
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
>
> ---
> string/string.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/string/string.h b/string/string.h
> index 54dd8344de..bfeeeb2eb4 100644
> --- a/string/string.h
> +++ b/string/string.h
> @@ -274,7 +274,7 @@ extern char *strrchr (const char *__s, int __c)
> __THROW __attribute_pure__ __nonnull ((1));
> #endif
>
> -#ifdef __USE_GNU
> +#ifdef __USE_MISC
> /* This function is similar to `strchr'. But it returns a pointer to
> the closing NUL byte in case C is not found in S. */
> # ifdef __CORRECT_ISO_CPP_STRING_H_PROTO
> @@ -368,7 +368,7 @@ extern char *strtok_r (char *__restrict __s, const char *__restrict __delim,
> __THROW __nonnull ((2, 3));
> #endif
>
> -#ifdef __USE_GNU
> +#ifdef __USE_MISC
> /* Similar to `strstr' but this function ignores the case of both strings. */
> # ifdef __CORRECT_ISO_CPP_STRING_H_PROTO
> extern "C++" char *strcasestr (char *__haystack, const char *__needle)
> @@ -382,7 +382,7 @@ extern char *strcasestr (const char *__haystack, const char *__needle)
> # endif
> #endif
>
> -#ifdef __USE_GNU
> +#ifdef __USE_MISC
> /* Find the first occurrence of NEEDLE in HAYSTACK.
> NEEDLE is NEEDLELEN bytes long;
> HAYSTACK is HAYSTACKLEN bytes long. */
>
> base-commit: a46956e65d037358161e7512a9f0fd408ea1333a
>
next prev parent reply other threads:[~2022-12-08 17:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-24 14:32 Florian Weimer
2022-12-08 17:07 ` Adhemerval Zanella Netto [this message]
2023-04-06 15:04 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a60df5ec-68ea-9d68-b707-2ef05ce2d5cb@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).