From: Carlos O'Donell <carlos@redhat.com>
To: Florian Weimer <fweimer@redhat.com>,
Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: libc-alpha@sourceware.org, "H . J . Lu" <hjl.tools@gmail.com>
Subject: Re: [PATCH v2] posix: Replace posix_spawnattr_tc{get, set}pgrp_np with posix_spawn_file_actions_addtcsetpgrp_np
Date: Tue, 1 Feb 2022 15:02:11 -0500 [thread overview]
Message-ID: <a8aeefc4-0c93-2984-6a41-b0867bbd4f12@redhat.com> (raw)
In-Reply-To: <87zgna1mkp.fsf@oldenburg.str.redhat.com>
On 2/1/22 13:14, Florian Weimer wrote:
> * Adhemerval Zanella:
>
>> @@ -235,6 +220,13 @@ posix_spawn_file_actions_addclosefrom_np (posix_spawn_file_actions_t *,
>> int __from)
>> __THROW __nonnull ((1));
>>
>> +/* Add an action fo set the terminal foregroup process group on the terminal
>
> Typo: foregrou[nd]
>
> The API addition looks okay to me.
>
> I've also checked that this patch passes build-many-glibcs.py.
I pulled the patch into Fedora Rawhide and reviews on x86_64, i686, s390x,
ppc64le, aarch64 and armv7hl. No issues there. My local x86_64 and i686
builders (non-rawhide with special configs with linux kernel head headers)
are also clean.
Let me go through a quick review and then we'll adjust the API for release.
--
Cheers,
Carlos.
next prev parent reply other threads:[~2022-02-01 20:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-29 20:06 Adhemerval Zanella
2022-02-01 18:14 ` [PATCH v2] posix: Replace posix_spawnattr_tc{get,set}pgrp_np " Florian Weimer
2022-02-01 20:02 ` Carlos O'Donell [this message]
2022-02-01 22:25 ` [PATCH v2] posix: Replace posix_spawnattr_tc{get, set}pgrp_np " Carlos O'Donell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8aeefc4-0c93-2984-6a41-b0867bbd4f12@redhat.com \
--to=carlos@redhat.com \
--cc=adhemerval.zanella@linaro.org \
--cc=fweimer@redhat.com \
--cc=hjl.tools@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).