public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Carlos O'Donell <carlos@redhat.com>
To: Simon Chopin <simon.chopin@canonical.com>,
	Palmer Dabbelt <palmer@rivosinc.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] Don't check signatures in build-many-glibcs.py
Date: Thu, 7 Mar 2024 15:44:01 -0500	[thread overview]
Message-ID: <aaed4686-9bce-4609-9847-b2825e2530dd@redhat.com> (raw)
In-Reply-To: <CAOOWow2Yr_xe+PsOQA8cZpeK+cydROF_-NQx+jSJy9n-KV8O4Q@mail.gmail.com>

On 3/6/24 05:39, Simon Chopin wrote:
> Hi Palmer, thanks for the patch.
> 
> On ven. 12 janv. 2024 10:58:46, Palmer Dabbelt wrote:
>> I sign commits and have signature verification on in git.  Maybe that's
>> a bad idea because it trips up a bunch of scripts, but it's pretty easy
>> to just force skipping signature verification here.
> 
> Presumably, there's all kind of things that could go wrong if the user
> has some particular git configuration. I feel like this particular can
> of worms could be side-stepped entirely if we just set GIT_CONFIG_GLOBAL
> to /dev/null (and perhaps used GIT_CONFIG_NOSYSTEM=1 for good measure)
> to clear any interfering custom config.

I agree completely.

If we need to we should reset tooling *defaults* so bmg runs as expected.
 
> WDYT?
> 
>>
>> Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
>> ---
>>  scripts/build-many-glibcs.py | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/scripts/build-many-glibcs.py b/scripts/build-many-glibcs.py
>> index ec2ded6e56..f9cf14c94d 100755
>> --- a/scripts/build-many-glibcs.py
>> +++ b/scripts/build-many-glibcs.py
>> @@ -931,7 +931,7 @@ class Context(object):
>>              if self.replace_sources:
>>                  subprocess.run(['git', 'clean', '-dxfq'],
>>                                 cwd=self.component_srcdir(component), check=True)
>> -            subprocess.run(['git', 'pull', '-q'],
>> +            subprocess.run(['git', 'pull', '-q', '--no-verify-signatures'],
>>                             cwd=self.component_srcdir(component), check=True)
>>          else:
>>              if self.shallow:
>> --
>> 2.43.0
>>
> 

-- 
Cheers,
Carlos.


  reply	other threads:[~2024-03-07 20:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-12 18:58 Palmer Dabbelt
2024-03-06 10:39 ` Simon Chopin
2024-03-07 20:44   ` Carlos O'Donell [this message]
2024-03-13  0:11     ` Palmer Dabbelt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aaed4686-9bce-4609-9847-b2825e2530dd@redhat.com \
    --to=carlos@redhat.com \
    --cc=libc-alpha@sourceware.org \
    --cc=palmer@rivosinc.com \
    --cc=simon.chopin@canonical.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).