From: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
To: Alejandro Colomar <alx.manpages@gmail.com>, libc-alpha@sourceware.org
Cc: Alejandro Colomar <alx@kernel.org>
Subject: Re: [PATCH v2 1/2] Fix invalid use of NULL in epoll_pwait2(2) test
Date: Thu, 1 Jun 2023 14:59:56 -0300 [thread overview]
Message-ID: <acfd4feb-1ed0-5cc8-6ed0-cce942817796@linaro.org> (raw)
In-Reply-To: <20230531204422.18052-1-alx@kernel.org>
On 31/05/23 17:44, Alejandro Colomar wrote:
> epoll_pwait2(2)'s second argument should be nonnull. We're going to add
> __nonnull to the prototype, so let's fix the test accordingly. We can
> use a dummy variable to avoid passing NULL.
>
> Reported-by: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
> Signed-off-by: Alejandro Colomar <alx@kernel.org>
LGTM, thanks.
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
> ---
> sysdeps/unix/sysv/linux/tst-epoll.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/sysdeps/unix/sysv/linux/tst-epoll.c b/sysdeps/unix/sysv/linux/tst-epoll.c
> index 66f091c202..abda45c427 100644
> --- a/sysdeps/unix/sysv/linux/tst-epoll.c
> +++ b/sysdeps/unix/sysv/linux/tst-epoll.c
> @@ -180,6 +180,8 @@ epoll_pwait2_check (int epfd, struct epoll_event *ev, int maxev, int tmo,
> static int
> do_test (void)
> {
> + struct epoll_event ev;
> +
> {
> struct sigaction sa;
> sa.sa_handler = handler;
> @@ -191,7 +193,7 @@ do_test (void)
> xsigaction (SIGCHLD, &sa, NULL);
> }
>
> - int r = epoll_pwait2 (-1, NULL, 0, NULL, NULL);
> + int r = epoll_pwait2 (-1, &ev, 0, NULL, NULL);
> TEST_COMPARE (r, -1);
> bool pwait2_supported = errno != ENOSYS;
>
next prev parent reply other threads:[~2023-06-01 18:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-19 22:50 nonnull on epoll_wait(2) syscall wrappers? Alejandro Colomar
2023-05-22 20:51 ` Adhemerval Zanella Netto
2023-05-22 22:01 ` [PATCH] Use __nonnull for the epoll_wait(2) family of syscalls Alejandro Colomar
2023-05-23 12:27 ` Adhemerval Zanella Netto
2023-05-29 17:39 ` Adhemerval Zanella Netto
2023-05-29 23:17 ` Alejandro Colomar
2023-05-30 11:41 ` Adhemerval Zanella Netto
2023-05-31 20:44 ` [PATCH v2 1/2] Fix invalid use of NULL in epoll_pwait2(2) test Alejandro Colomar
2023-06-01 17:59 ` Adhemerval Zanella Netto [this message]
2023-05-31 20:44 ` [PATCH v2 2/2] Use __nonnull for the epoll_wait(2) family of syscalls Alejandro Colomar
2023-06-01 18:00 ` Adhemerval Zanella Netto
2023-06-01 23:46 ` Alejandro Colomar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acfd4feb-1ed0-5cc8-6ed0-cce942817796@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=alx.manpages@gmail.com \
--cc=alx@kernel.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).