From: Xi Ruoyao <xry111@xry111.site>
To: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>,
Carlos O'Donell <carlos@redhat.com>,
libc-alpha@sourceware.org
Cc: caiyinyu <caiyinyu@loongson.cn>, Wang Xuerui <i@xen0n.name>
Subject: Re: [PATCH] LoongArch: ldconfig: Ignore EF_LARCH_OBJABI_V1 in shared objects
Date: Tue, 28 Mar 2023 01:46:00 +0800 [thread overview]
Message-ID: <ae9744cedbcacb978f4e5302cbde55b6a53c8727.camel@xry111.site> (raw)
In-Reply-To: <d2d239aa-75ed-847d-d97b-465a85bd47d4@linaro.org>
On Mon, 2023-03-27 at 13:54 -0300, Adhemerval Zanella Netto wrote:
> Since the boat is already sailed with 2.40, I think the proposed patch
> is fine (it would be better if you indeed fix it on 2.41). I would
> just like to add a comment on why this is required:
>
> /* The EF_LARCH_OBJABI_V1 flag indicate which set of static relocations
> the object might use and it only considered during static linking,
> it does not reflect in runtime relocations. However some binutils
> version might set it on dynamic shared object, so clear it to avoid
> see the SO as unsupported. */
Looks like Yinyu has already landed the patch.
Yinyu: could you add this comment before the changed line? I don't have
a write access.
--
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University
next prev parent reply other threads:[~2023-03-27 17:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-26 11:13 Xi Ruoyao
2023-03-27 13:44 ` Carlos O'Donell
2023-03-27 14:57 ` Xi Ruoyao
2023-03-27 16:54 ` Adhemerval Zanella Netto
2023-03-27 17:46 ` Xi Ruoyao [this message]
2023-03-29 13:12 ` Carlos O'Donell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae9744cedbcacb978f4e5302cbde55b6a53c8727.camel@xry111.site \
--to=xry111@xry111.site \
--cc=adhemerval.zanella@linaro.org \
--cc=caiyinyu@loongson.cn \
--cc=carlos@redhat.com \
--cc=i@xen0n.name \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).