From: Joseph Myers <joseph@codesourcery.com>
To: "Gabriel F. T. Gomes" <gftg@linux.vnet.ibm.com>
Cc: <libc-alpha@sourceware.org>
Subject: Re: [PATCH v8 3/3] Add tests for strfrom functions
Date: Fri, 14 Oct 2016 21:40:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.20.1610142134100.32709@digraph.polyomino.org.uk> (raw)
In-Reply-To: <1476466285-17655-4-git-send-email-gftg@linux.vnet.ibm.com>
On Fri, 14 Oct 2016, Gabriel F. T. Gomes wrote:
> + double val;
Some of the test arrays are still using double rather than using the type
under test in a type-generic way (thus, either having multiple arrays or
having a struct member per type as in the tst-strtod-round tests).
> +struct val
> +{
> + float f;
> + double d;
> + long double ld;
> +};
Although this one has a struct with multiple types, it's not properly
type-generic. I'd expect use of something like STRUCT_FOREACH_FLOAT_FTYPE
(in tst-strtod-round-skeleton.c) to define such a struct, and then such a
macro concatenting a suffix to the constants to fill in the initializers.
If the tests are properly type-generic, only GEN_TEST_STRTOD_FOREACH /
STRTOD_TEST_FOREACH in tst-strtod.h should likely need to change to make
them cover an extra type.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2016-10-14 21:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-14 17:31 [PATCH v8 0/3] New " Gabriel F. T. Gomes
2016-10-14 17:31 ` [PATCH v8 2/3] Refactor strtod tests Gabriel F. T. Gomes
2016-10-14 17:31 ` [PATCH v8 1/3] Add strfromd, strfromf, and strfroml functions Gabriel F. T. Gomes
2016-10-14 17:31 ` [PATCH v8 3/3] Add tests for strfrom functions Gabriel F. T. Gomes
2016-10-14 18:50 ` Gabriel F. T. Gomes
2016-10-14 21:40 ` Joseph Myers [this message]
2016-10-18 15:08 ` [PATCH v9 " Gabriel F. T. Gomes
2016-10-20 16:56 ` Joseph Myers
2016-10-24 14:57 ` [PATCH v10 " Gabriel F. T. Gomes
2016-10-25 16:18 ` Joseph Myers
2016-10-26 0:27 ` Gabriel F. T. Gomes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1610142134100.32709@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=gftg@linux.vnet.ibm.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).