public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
* Do not generate UNRESOLVED results for run-built-tests = no
@ 2016-11-02 23:49 Joseph Myers
  2016-11-04 21:10 ` Roland McGrath
  0 siblings, 1 reply; 2+ messages in thread
From: Joseph Myers @ 2016-11-02 23:49 UTC (permalink / raw)
  To: libc-alpha

Testing with run-built-tests = no generates many UNRESOLVED results in
tests.sum (and so in the output of "make check"), for all the tests
that are only compiled and not run in such a configuration.  This
doesn't seem useful in the "make check" output, and also causes "make
check" to exist with error status even when all tests that can be run
in such a configuration passed.

This patch changes it not to consider those tests when generating
subdir-tests.sum, and so tests.sum, so that you get a smaller number
of tests considered in the final results rather than a huge pile of
UNRESOLVED.

Tested with a cross-compiler to ARM in a run-built-tests = no
configuration.

2016-11-02  Joseph Myers  <joseph@codesourcery.com>

	* Rules (tests-expected): New variable, depending on
	$(run-built-tests).
	(tests): Pass $(tests-expected) to merge-test-results.sh, not
	$(tests).

diff --git a/Rules b/Rules
index 4b95997..466db07 100644
--- a/Rules
+++ b/Rules
@@ -124,9 +124,14 @@ endif
 
 tests-special-notdir = $(patsubst $(objpfx)%, %, $(tests-special))
 xtests-special-notdir = $(patsubst $(objpfx)%, %, $(xtests-special))
+ifeq ($(run-built-tests),no)
+tests-expected =
+else
+tests-expected = $(tests)
+endif
 tests:
 	$(..)scripts/merge-test-results.sh -s $(objpfx) $(subdir) \
-	  $(sort $(tests) $(tests-special-notdir:.out=)) \
+	  $(sort $(tests-expected) $(tests-special-notdir:.out=)) \
 	  > $(objpfx)subdir-tests.sum
 xtests:
 	$(..)scripts/merge-test-results.sh -s $(objpfx) $(subdir) \

-- 
Joseph S. Myers
joseph@codesourcery.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Do not generate UNRESOLVED results for run-built-tests = no
  2016-11-02 23:49 Do not generate UNRESOLVED results for run-built-tests = no Joseph Myers
@ 2016-11-04 21:10 ` Roland McGrath
  0 siblings, 0 replies; 2+ messages in thread
From: Roland McGrath @ 2016-11-04 21:10 UTC (permalink / raw)
  To: Joseph Myers; +Cc: libc-alpha

OK

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-11-04 21:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-02 23:49 Do not generate UNRESOLVED results for run-built-tests = no Joseph Myers
2016-11-04 21:10 ` Roland McGrath

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).