From: Joseph Myers <joseph@codesourcery.com>
To: Chris Metcalf <cmetcalf@mellanox.com>
Cc: <libc-alpha@sourceware.org>
Subject: Re: Library directories for tilegx
Date: Fri, 04 Nov 2016 13:33:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.20.1611041332300.1065@digraph.polyomino.org.uk> (raw)
In-Reply-To: <691b37f4-437f-67b5-5a0c-d5ce31ea1604@mellanox.com>
On Thu, 3 Nov 2016, Chris Metcalf wrote:
> On 11/3/2016 7:08 PM, Joseph Myers wrote:
> > Incidentally, I found another issue in building: GCC has a tilegxbe-*
> > target name for big-endian, but sysdeps/tile/preconfigure only handles
> > tilegx, not tilegxbe. However, that's easy to work around by configuring
> > glibc for a different triplet from GCC.
>
> Good point. I don't actually test tilegxbe; I don't think we ever had a lot
> of interest in that version of the toolchain. I will try to remember to add
> it next time I do tests, and I can push up a fix to preconfigure at that point
> too (or feel free to push one yourself).
Fix pushed thus.
Handle tilegx* machine names.
This patch makes sysdeps/tile/preconfigure handle tilegx* machine
names instead of just plain tilegx. That matches GCC, and in
particular allows a big-endian toolchain to use the tilegxbe-linux-gnu
name when configuring both GCC and glibc.
Tested with compilation for tilegxbe-linux-gnu, both 32-bit and 64-bit
(building a subsequent GCC against that glibc still falls over because
of both 32-bit and 64-bit libraries going in the lib directory, as
noted at
<https://sourceware.org/ml/libc-alpha/2016-11/msg00129.html>).
2016-11-04 Joseph Myers <joseph@codesourcery.com>
* sysdeps/tile/preconfigure: Accept tilegx* instead of tilegx.
diff --git a/sysdeps/tile/preconfigure b/sysdeps/tile/preconfigure
index dfe050c..f3e5d7e 100644
--- a/sysdeps/tile/preconfigure
+++ b/sysdeps/tile/preconfigure
@@ -2,7 +2,7 @@
case "$machine" in
tilepro)
base_machine=tile machine=tile/tilepro ;;
- tilegx)
+ tilegx*)
base_machine=tile
if $CC $CFLAGS $CPPFLAGS -E -dM -xc /dev/null | grep -q __LP64__; then
machine=tile/tilegx/tilegx64
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2016-11-04 13:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-04 0:44 Joseph Myers
2016-11-04 1:01 ` Chris Metcalf
2016-11-04 1:08 ` Joseph Myers
2016-11-04 1:50 ` Chris Metcalf
2016-11-04 13:33 ` Joseph Myers [this message]
2016-11-04 15:12 ` Chris Metcalf
2016-11-07 16:26 ` Joseph Myers
2016-11-07 21:48 ` Chris Metcalf
2016-11-09 0:35 ` Joseph Myers
2016-11-14 20:12 ` Chris Metcalf
2016-11-14 22:59 ` Joseph Myers
2016-11-14 23:25 ` Chris Metcalf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1611041332300.1065@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=cmetcalf@mellanox.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).