* Ignore -Wmaybe-uninitialized in stdlib/bug-getcontext.c
@ 2016-11-04 17:27 Joseph Myers
2016-11-11 15:03 ` Ping " Joseph Myers
0 siblings, 1 reply; 3+ messages in thread
From: Joseph Myers @ 2016-11-04 17:27 UTC (permalink / raw)
To: libc-alpha
Doing all-ABIs compile testing produces a compiler warning in
stdlib/bug-getcontext.c on nios2 and tilepro (with GCC 5 branch):
bug-getcontext.c: In function 'do_test':
bug-getcontext.c:53:6: error: 'except_mask' may be used uninitialized in this function [-Werror=maybe-uninitialized]
if (mask != except_mask)
^
This warning appears nonsensical; except_mask is initialized where
it's declared. I think what must be happening here is that the
compiler is confused by the returns-twice nature of getcontext: if
there were a call to setcontext, local variables could indeed have
lost their values on the second return from getcontext. This patch
duly uses the DIAG_* macros to disable the warning here.
Tested for nios2 and tilepro (compilation only; after this patch all
the tests compile, though there are other failures) and x86_64 (full
testsuite run).
2016-11-04 Joseph Myers <joseph@codesourcery.com>
* stdlib/bug-getcontext.c: Include <libc-internal.h>.
(do_test): Disable -Wmaybe-uninitialized around uses of
except_mask.
diff --git a/stdlib/bug-getcontext.c b/stdlib/bug-getcontext.c
index 133ee91..c407212 100644
--- a/stdlib/bug-getcontext.c
+++ b/stdlib/bug-getcontext.c
@@ -5,6 +5,7 @@
#include <stdio.h>
#include <stdlib.h>
#include <ucontext.h>
+#include <libc-internal.h>
static int
do_test (void)
@@ -49,6 +50,13 @@ do_test (void)
printf ("\nDone with getcontext()!\n");
fflush (NULL);
+ /* On nios2 and tilepro, GCC 5 warns that except_mask may be used
+ uninitialized. Because it is always initialized and nothing in
+ this test ever calls setcontext (a setcontext call could result
+ in local variables being clobbered on the second return from
+ getcontext), in fact an uninitialized use is not possible. */
+ DIAG_PUSH_NEEDS_COMMENT;
+ DIAG_IGNORE_NEEDS_COMMENT (5, "-Wmaybe-uninitialized");
int mask = fegetexcept ();
if (mask != except_mask)
{
@@ -59,6 +67,7 @@ do_test (void)
printf("\nAt end fegetexcept() returned %d, expected: %d.\n",
mask, except_mask);
+ DIAG_POP_NEEDS_COMMENT;
return 0;
}
--
Joseph S. Myers
joseph@codesourcery.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Ping Re: Ignore -Wmaybe-uninitialized in stdlib/bug-getcontext.c
2016-11-04 17:27 Ignore -Wmaybe-uninitialized in stdlib/bug-getcontext.c Joseph Myers
@ 2016-11-11 15:03 ` Joseph Myers
2016-11-11 19:40 ` Carlos O'Donell
0 siblings, 1 reply; 3+ messages in thread
From: Joseph Myers @ 2016-11-11 15:03 UTC (permalink / raw)
To: libc-alpha
Ping. This patch
<https://sourceware.org/ml/libc-alpha/2016-11/msg00189.html> is pending
review.
--
Joseph S. Myers
joseph@codesourcery.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Ping Re: Ignore -Wmaybe-uninitialized in stdlib/bug-getcontext.c
2016-11-11 15:03 ` Ping " Joseph Myers
@ 2016-11-11 19:40 ` Carlos O'Donell
0 siblings, 0 replies; 3+ messages in thread
From: Carlos O'Donell @ 2016-11-11 19:40 UTC (permalink / raw)
To: Joseph Myers, libc-alpha
On 11/11/2016 10:03 AM, Joseph Myers wrote:
> Ping. This patch
> <https://sourceware.org/ml/libc-alpha/2016-11/msg00189.html> is pending
> review.
>
Reviewed file, warnings, and changes.
Looks good to me.
--
Cheers,
Carlos.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-11-11 19:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-04 17:27 Ignore -Wmaybe-uninitialized in stdlib/bug-getcontext.c Joseph Myers
2016-11-11 15:03 ` Ping " Joseph Myers
2016-11-11 19:40 ` Carlos O'Donell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).