* Work around IA64 tst-setcontext2.c compile failure
@ 2016-11-09 2:05 Joseph Myers
2016-11-15 21:53 ` Ping " Joseph Myers
2016-11-28 20:43 ` Florian Weimer
0 siblings, 2 replies; 5+ messages in thread
From: Joseph Myers @ 2016-11-09 2:05 UTC (permalink / raw)
To: libc-alpha, vapier
Building tests for IA64 runs into a build failure compiling
stdlib/tst-setcontext2.c:
tst-setcontext2.c: In function 'do_test':
tst-setcontext2.c:210:20: error: passing argument 1 of 'sigismember' from incompatible pointer type [-Werror=incompatible-pointer-types]
if (sigismember (&oldctx.uc_sigmask, SIGUSR2) != 1)
^
Indeed, the IA64 uc_sigmask as unsigned long rather than the larger
userspace sigset_t. Fixing this might be hard; this patch works
around the build failure by making IA64 wrap the test with a version
that #defines sigismember to add a cast (I'd welcome a better approach
for fixing this).
Tested (compilation only) for ia64.
2016-11-09 Joseph Myers <joseph@codesourcery.com>
* sysdeps/unix/sysv/linux/ia64/tst-setcontext2.c: New file.
diff --git a/sysdeps/unix/sysv/linux/ia64/tst-setcontext2.c b/sysdeps/unix/sysv/linux/ia64/tst-setcontext2.c
new file mode 100644
index 0000000..7adc059
--- /dev/null
+++ b/sysdeps/unix/sysv/linux/ia64/tst-setcontext2.c
@@ -0,0 +1,24 @@
+/* Work around incorrect type of IA64 uc_sigmask.
+ Copyright (C) 2016 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <http://www.gnu.org/licenses/>. */
+
+#include <signal.h>
+
+#undef sigismember
+#define sigismember(set, signo) sigismember ((const sigset_t *) (set), (signo))
+
+#include <stdlib/tst-setcontext2.c>
--
Joseph S. Myers
joseph@codesourcery.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* Ping Re: Work around IA64 tst-setcontext2.c compile failure
2016-11-09 2:05 Work around IA64 tst-setcontext2.c compile failure Joseph Myers
@ 2016-11-15 21:53 ` Joseph Myers
2016-11-21 16:47 ` Ping^2 " Joseph Myers
2016-11-28 20:43 ` Florian Weimer
1 sibling, 1 reply; 5+ messages in thread
From: Joseph Myers @ 2016-11-15 21:53 UTC (permalink / raw)
To: libc-alpha, vapier
Ping. This patch
<https://sourceware.org/ml/libc-alpha/2016-11/msg00314.html> is pending
review.
--
Joseph S. Myers
joseph@codesourcery.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* Ping^2 Re: Work around IA64 tst-setcontext2.c compile failure
2016-11-15 21:53 ` Ping " Joseph Myers
@ 2016-11-21 16:47 ` Joseph Myers
2016-11-28 18:10 ` Ping^3 " Joseph Myers
0 siblings, 1 reply; 5+ messages in thread
From: Joseph Myers @ 2016-11-21 16:47 UTC (permalink / raw)
To: libc-alpha, vapier
Ping^2. This patch
<https://sourceware.org/ml/libc-alpha/2016-11/msg00314.html> is still
pending review.
--
Joseph S. Myers
joseph@codesourcery.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* Ping^3 Re: Work around IA64 tst-setcontext2.c compile failure
2016-11-21 16:47 ` Ping^2 " Joseph Myers
@ 2016-11-28 18:10 ` Joseph Myers
0 siblings, 0 replies; 5+ messages in thread
From: Joseph Myers @ 2016-11-28 18:10 UTC (permalink / raw)
To: libc-alpha, vapier
Ping^3. This patch
<https://sourceware.org/ml/libc-alpha/2016-11/msg00314.html> is still
pending review.
--
Joseph S. Myers
joseph@codesourcery.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Work around IA64 tst-setcontext2.c compile failure
2016-11-09 2:05 Work around IA64 tst-setcontext2.c compile failure Joseph Myers
2016-11-15 21:53 ` Ping " Joseph Myers
@ 2016-11-28 20:43 ` Florian Weimer
1 sibling, 0 replies; 5+ messages in thread
From: Florian Weimer @ 2016-11-28 20:43 UTC (permalink / raw)
To: Joseph Myers, libc-alpha, vapier
On 11/09/2016 03:05 AM, Joseph Myers wrote:
> Tested (compilation only) for ia64.
>
> 2016-11-09 Joseph Myers <joseph@codesourcery.com>
>
> * sysdeps/unix/sysv/linux/ia64/tst-setcontext2.c: New file.
Please feel encouraged to commit this.
Honestly, I don't really know what to do with these old architectures.
Thanks,
Florian
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-11-28 20:43 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-09 2:05 Work around IA64 tst-setcontext2.c compile failure Joseph Myers
2016-11-15 21:53 ` Ping " Joseph Myers
2016-11-21 16:47 ` Ping^2 " Joseph Myers
2016-11-28 18:10 ` Ping^3 " Joseph Myers
2016-11-28 20:43 ` Florian Weimer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).