From: Joseph Myers <joseph@codesourcery.com>
To: "Gabriel F. T. Gomes" <gftg@linux.vnet.ibm.com>
Cc: <libc-alpha@sourceware.org>
Subject: Re: [PATCH 0/8] More float128 declarations
Date: Wed, 09 Nov 2016 23:52:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.20.1611092345500.6428@digraph.polyomino.org.uk> (raw)
In-Reply-To: <alpine.DEB.2.20.1611092129260.6428@digraph.polyomino.org.uk>
On Wed, 9 Nov 2016, Joseph Myers wrote:
> This seems inconsistent about whether the recently added TS 18661-1
> functions are covered or not. I'd expect all of the following to have
> version map entries: __iseqsigf128 totalorderf128 totalordermagf128
> getpayloadf128 canonicalizef128, and, where the definitions aren't
> type-generic, to have function definitions for float128.
Also, this inconsistency suggests to me that the patches haven't been
testing in conjunction with subsequent patches that actually enable the
new functions and their associated tests, because the tests would have
failed to link if some functions were absent.
Anything that involves adding new files / declarations / macros for each
new function should probably best have its final review as part of the
patch series that actually enables the new functions and associated tests
for at least one system, as otherwise it's hard to have confidence in the
completeness and correctness of the changes. (That is, while it's
possible to spot some issues without such testing, final approval of such
patches should wait until the code for the new types has gone through
testing. Whereas e.g. a conversion of math-finite.h to use macros to
declare functions could be done in a way involving no float128
conditionals at all, so entirely suitable to review by itself, with the
float128 patches then just adapting the macro definitions to handle
float128.)
--
Joseph S. Myers
joseph@codesourcery.com
prev parent reply other threads:[~2016-11-09 23:52 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-09 18:41 Gabriel F. T. Gomes
2016-11-09 18:41 ` [PATCH 1/8] ldbl-128: Use mathx_hidden_def inplace of hidden_def Gabriel F. T. Gomes
2016-11-09 18:41 ` [PATCH 3/8] float128: Add wrappers for IEEE functions Gabriel F. T. Gomes
2016-11-09 21:38 ` Joseph Myers
2016-12-05 16:48 ` Gabriel F. T. Gomes
2016-12-05 18:51 ` Joseph Myers
2016-12-05 22:52 ` Steven Munroe
2016-12-06 0:31 ` Joseph Myers
2016-12-06 2:39 ` Steven Munroe
2016-12-07 19:36 ` Gabriel F. T. Gomes
2016-12-07 21:47 ` Joseph Myers
2016-12-09 21:24 ` Gabriel F. T. Gomes
2016-12-14 0:47 ` Joseph Myers
2016-12-14 13:36 ` Gabriel F. T. Gomes
2016-12-14 14:33 ` Joseph Myers
2016-11-09 18:41 ` [PATCH 6/8] float128: Expose _Float128 finite math functions Gabriel F. T. Gomes
2016-11-09 22:06 ` Joseph Myers
2017-03-03 20:17 ` Gabriel F. T. Gomes
2017-03-03 20:50 ` Joseph Myers
2016-11-09 18:41 ` [PATCH 4/8] Add support for testing __STDC_WANT_IEC_60559_TYPES_EXT__ Gabriel F. T. Gomes
2016-11-09 21:42 ` Joseph Myers
2016-11-09 18:41 ` [PATCH 5/8] float128: Add public _Float128 declarations to libm Gabriel F. T. Gomes
2016-11-09 22:04 ` Joseph Myers
2016-11-09 18:41 ` [PATCH 8/8] float128: Add wrappers to override ldbl-128 as float128 Gabriel F. T. Gomes
2016-11-09 22:13 ` Joseph Myers
2016-11-09 18:41 ` [PATCH 2/8] float128: Add _Float128 make bits to libm Gabriel F. T. Gomes
2016-12-09 21:23 ` Tulio Magno Quites Machado Filho
2016-12-12 22:49 ` Joseph Myers
2016-11-09 18:41 ` [PATCH 7/8] float128: Add private _Float128 declarations for libm Gabriel F. T. Gomes
2016-11-09 22:08 ` Joseph Myers
2016-11-10 22:13 ` Joseph Myers
2016-11-09 21:31 ` [PATCH 0/8] More float128 declarations Joseph Myers
2016-11-09 23:52 ` Joseph Myers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1611092345500.6428@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=gftg@linux.vnet.ibm.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).