From: Joseph Myers <joseph@codesourcery.com>
To: Tulio Magno Quites Machado Filho <tuliom@linux.vnet.ibm.com>
Cc: "Gabriel F. T. Gomes" <gftg@linux.vnet.ibm.com>,
<libc-alpha@sourceware.org>
Subject: Re: [PATCH 2/8] float128: Add _Float128 make bits to libm.
Date: Mon, 12 Dec 2016 22:49:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.20.1612122230560.11503@digraph.polyomino.org.uk> (raw)
In-Reply-To: <87oa0ker0u.fsf@linux.vnet.ibm.com>
On Fri, 9 Dec 2016, Tulio Magno Quites Machado Filho wrote:
> "Gabriel F. T. Gomes" <gftg@linux.vnet.ibm.com> writes:
>
> > From: "Paul E. Murphy" <murphyp@linux.vnet.ibm.com>
> >
> > This adds the appropriate common bits for a platform to
> > enable float128 and expose ABI.
>
> Joseph, I'd like to clarify one thing:
> In a previous thread you mentioned that you'd review one patch of a
> patchset after fixing/committing the previous patch.
>
> In this patchset, you replied directly to patch #3, without making comments to
> patch #1 and #2. Does that mean they look good for you?
No. There can be cases where dependencies among patches in a series, and
the likelihood of issues with one patch requiring changes to subsequent
patches, can mean that latter patches are more reviewable once earlier
patches have passed their final review. And it may well end up that this
series is like that. But for the series posted on 9 Nov I didn't do that.
Instead, I did an initial general pass over the whole patch series to
identify the most obvious issues - with all patches rather than just the
first ones, so all patches can be updated accordingly for the next
iteration of the series.
I did comment on patch 2 - in my general comments on patch 0, relating to
having the correct, consistent API/ABI exposed for the new types through
the whole patch series, which affect patch 2 as well as other patches.
https://sourceware.org/ml/libc-alpha/2016-11/msg00361.html
https://sourceware.org/ml/libc-alpha/2016-11/msg00370.html
(Note also the point there that when it comes to such things involving
long lists of functions for the new type - in the cases where it's
unavoidable to have such long lists, as opposed to the cases where
existing lists for existing types can be macroized - one can have more
confidence in the completeness of the list if the patch series as a whole
has passed testing with existing libm tests enabled for the new type, so
showing through the testsuite that all the expected functions are indeed
exported for that type.)
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2016-12-12 22:49 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-09 18:41 [PATCH 0/8] More float128 declarations Gabriel F. T. Gomes
2016-11-09 18:41 ` [PATCH 1/8] ldbl-128: Use mathx_hidden_def inplace of hidden_def Gabriel F. T. Gomes
2016-11-09 18:41 ` [PATCH 6/8] float128: Expose _Float128 finite math functions Gabriel F. T. Gomes
2016-11-09 22:06 ` Joseph Myers
2017-03-03 20:17 ` Gabriel F. T. Gomes
2017-03-03 20:50 ` Joseph Myers
2016-11-09 18:41 ` [PATCH 3/8] float128: Add wrappers for IEEE functions Gabriel F. T. Gomes
2016-11-09 21:38 ` Joseph Myers
2016-12-05 16:48 ` Gabriel F. T. Gomes
2016-12-05 18:51 ` Joseph Myers
2016-12-05 22:52 ` Steven Munroe
2016-12-06 0:31 ` Joseph Myers
2016-12-06 2:39 ` Steven Munroe
2016-12-07 19:36 ` Gabriel F. T. Gomes
2016-12-07 21:47 ` Joseph Myers
2016-12-09 21:24 ` Gabriel F. T. Gomes
2016-12-14 0:47 ` Joseph Myers
2016-12-14 13:36 ` Gabriel F. T. Gomes
2016-12-14 14:33 ` Joseph Myers
2016-11-09 18:41 ` [PATCH 4/8] Add support for testing __STDC_WANT_IEC_60559_TYPES_EXT__ Gabriel F. T. Gomes
2016-11-09 21:42 ` Joseph Myers
2016-11-09 18:41 ` [PATCH 5/8] float128: Add public _Float128 declarations to libm Gabriel F. T. Gomes
2016-11-09 22:04 ` Joseph Myers
2016-11-09 18:41 ` [PATCH 2/8] float128: Add _Float128 make bits " Gabriel F. T. Gomes
2016-12-09 21:23 ` Tulio Magno Quites Machado Filho
2016-12-12 22:49 ` Joseph Myers [this message]
2016-11-09 18:41 ` [PATCH 8/8] float128: Add wrappers to override ldbl-128 as float128 Gabriel F. T. Gomes
2016-11-09 22:13 ` Joseph Myers
2016-11-09 18:41 ` [PATCH 7/8] float128: Add private _Float128 declarations for libm Gabriel F. T. Gomes
2016-11-09 22:08 ` Joseph Myers
2016-11-10 22:13 ` Joseph Myers
2016-11-09 21:31 ` [PATCH 0/8] More float128 declarations Joseph Myers
2016-11-09 23:52 ` Joseph Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1612122230560.11503@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=gftg@linux.vnet.ibm.com \
--cc=libc-alpha@sourceware.org \
--cc=tuliom@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).