From: Joseph Myers <joseph@codesourcery.com>
To: Chris Metcalf <cmetcalf@mellanox.com>
Cc: <libc-alpha@sourceware.org>
Subject: Re: [PATCH] Make tile's set_dataplane API compatibility-only
Date: Mon, 14 Nov 2016 17:00:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.20.1611141658550.1171@digraph.polyomino.org.uk> (raw)
In-Reply-To: <1479142545-13207-1-git-send-email-cmetcalf@mellanox.com>
On Mon, 14 Nov 2016, Chris Metcalf wrote:
> diff --git a/sysdeps/unix/sysv/linux/tile/set_dataplane.c b/sysdeps/unix/sysv/linux/tile/set_dataplane.c
> index 5a4bffe4f311..e2ea896e88d0 100644
> --- a/sysdeps/unix/sysv/linux/tile/set_dataplane.c
> +++ b/sysdeps/unix/sysv/linux/tile/set_dataplane.c
> @@ -23,9 +23,9 @@
> #include <sys/dataplane.h>
> #endif
>
> -/* Request dataplane modes from the kernel. */
> +/* Request dataplane modes from the kernel (compatibility only). */
> int
> -set_dataplane (int flags)
> +__old_set_dataplane (int flags)
> {
> #ifdef __NR_set_dataplane
> return INLINE_SYSCALL (set_dataplane, 1, flags);
> @@ -34,3 +34,7 @@ set_dataplane (int flags)
> return -1;
> #endif
> }
> +
> +#if SHLIB_COMPAT (libc, GLIBC_2_12, GLIBC_2_25)
> +compat_symbol (libc, __old_set_dataplane, set_dataplane, GLIBC_2_12);
> +#endif
I'd expect the function definition to be under the SHLIB_COMPAT
conditional as well, so the object file has no code in the static libc.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2016-11-14 17:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-04 22:05 tilepro glibc problems Joseph Myers
2016-11-04 22:25 ` Chris Metcalf
2016-11-14 16:56 ` [PATCH] Make tile's set_dataplane API compatibility-only Chris Metcalf
2016-11-14 17:00 ` Joseph Myers [this message]
2016-11-14 20:05 ` [PATCH v2] " Chris Metcalf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1611141658550.1171@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=cmetcalf@mellanox.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).