* Make Alpha <sys/user.h> self-contained @ 2016-11-04 16:47 Joseph Myers 2016-11-11 15:02 ` Ping " Joseph Myers 0 siblings, 1 reply; 6+ messages in thread From: Joseph Myers @ 2016-11-04 16:47 UTC (permalink / raw) To: libc-alpha; +Cc: rth The check-installed-headers tests show up that the Alpha <sys/user.h> is not self-contained, using size_t without including any header that defines it. This patch fixes it by including <stddef.h>, as done for other architectures' versions of this header. Tested for Alpha (compilation only). 2016-11-04 Joseph Myers <joseph@codesourcery.com> * sysdeps/unix/sysv/linux/alpha/sys/user.h: Include <stddef.h>. diff --git a/sysdeps/unix/sysv/linux/alpha/sys/user.h b/sysdeps/unix/sysv/linux/alpha/sys/user.h index 1a7c9c4..3d0d76b 100644 --- a/sysdeps/unix/sysv/linux/alpha/sys/user.h +++ b/sysdeps/unix/sysv/linux/alpha/sys/user.h @@ -23,6 +23,7 @@ than gdb/strace unless you know what you are doing. */ #include <asm/reg.h> +#include <stddef.h> struct user { -- Joseph S. Myers joseph@codesourcery.com ^ permalink raw reply [flat|nested] 6+ messages in thread
* Ping Re: Make Alpha <sys/user.h> self-contained 2016-11-04 16:47 Make Alpha <sys/user.h> self-contained Joseph Myers @ 2016-11-11 15:02 ` Joseph Myers 2016-11-11 19:41 ` Carlos O'Donell 2016-11-16 18:13 ` Ping^2 " Joseph Myers 0 siblings, 2 replies; 6+ messages in thread From: Joseph Myers @ 2016-11-11 15:02 UTC (permalink / raw) To: libc-alpha; +Cc: rth Ping. This patch <https://sourceware.org/ml/libc-alpha/2016-11/msg00182.html> is pending review. -- Joseph S. Myers joseph@codesourcery.com ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Ping Re: Make Alpha <sys/user.h> self-contained 2016-11-11 15:02 ` Ping " Joseph Myers @ 2016-11-11 19:41 ` Carlos O'Donell 2016-11-11 21:08 ` Joseph Myers 2016-11-16 18:13 ` Ping^2 " Joseph Myers 1 sibling, 1 reply; 6+ messages in thread From: Carlos O'Donell @ 2016-11-11 19:41 UTC (permalink / raw) To: Joseph Myers, libc-alpha; +Cc: rth On 11/11/2016 10:02 AM, Joseph Myers wrote: > Ping. This patch > <https://sourceware.org/ml/libc-alpha/2016-11/msg00182.html> is pending > review. > You don't need review for this? https://sourceware.org/glibc/wiki/Consensus#Trivial_Bug-Fix_Changes ~~~ Anyone can commit a change adding missing #include directives where it is clear what the right header is for functionality used in a source file. Post the patch and ChangeLog to libc-alpha with a short message and then push the commit. ~~~ LGTM. -- Cheers, Carlos. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Ping Re: Make Alpha <sys/user.h> self-contained 2016-11-11 19:41 ` Carlos O'Donell @ 2016-11-11 21:08 ` Joseph Myers 0 siblings, 0 replies; 6+ messages in thread From: Joseph Myers @ 2016-11-11 21:08 UTC (permalink / raw) To: Carlos O'Donell; +Cc: libc-alpha, rth On Fri, 11 Nov 2016, Carlos O'Donell wrote: > On 11/11/2016 10:02 AM, Joseph Myers wrote: > > Ping. This patch > > <https://sourceware.org/ml/libc-alpha/2016-11/msg00182.html> is pending > > review. > > > > You don't need review for this? > > https://sourceware.org/glibc/wiki/Consensus#Trivial_Bug-Fix_Changes > > ~~~ > Anyone can commit a change adding missing #include directives where > it is clear what the right header is for functionality used in a > source file. Post the patch and ChangeLog to libc-alpha with a > short message and then push the commit. I don't think of that as applying to installed headers. -- Joseph S. Myers joseph@codesourcery.com ^ permalink raw reply [flat|nested] 6+ messages in thread
* Ping^2 Re: Make Alpha <sys/user.h> self-contained 2016-11-11 15:02 ` Ping " Joseph Myers 2016-11-11 19:41 ` Carlos O'Donell @ 2016-11-16 18:13 ` Joseph Myers 2016-11-17 8:25 ` Richard Henderson 1 sibling, 1 reply; 6+ messages in thread From: Joseph Myers @ 2016-11-16 18:13 UTC (permalink / raw) To: libc-alpha; +Cc: rth Ping^2. This patch <https://sourceware.org/ml/libc-alpha/2016-11/msg00182.html> is still pending review. -- Joseph S. Myers joseph@codesourcery.com ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Ping^2 Re: Make Alpha <sys/user.h> self-contained 2016-11-16 18:13 ` Ping^2 " Joseph Myers @ 2016-11-17 8:25 ` Richard Henderson 0 siblings, 0 replies; 6+ messages in thread From: Richard Henderson @ 2016-11-17 8:25 UTC (permalink / raw) To: Joseph Myers, libc-alpha; +Cc: rth On 11/16/2016 07:13 PM, Joseph Myers wrote: > Ping^2. This patch > <https://sourceware.org/ml/libc-alpha/2016-11/msg00182.html> is still > pending review. > Ack. r~ ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-11-17 8:25 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2016-11-04 16:47 Make Alpha <sys/user.h> self-contained Joseph Myers 2016-11-11 15:02 ` Ping " Joseph Myers 2016-11-11 19:41 ` Carlos O'Donell 2016-11-11 21:08 ` Joseph Myers 2016-11-16 18:13 ` Ping^2 " Joseph Myers 2016-11-17 8:25 ` Richard Henderson
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).