From: Joseph Myers <joseph@codesourcery.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: <libc-alpha@sourceware.org>, Chung-Lin Tang <cltang@codesourcery.com>
Subject: Re: nios2 sys/cachectl.h includes nonexistent asm/cachectl.h
Date: Wed, 16 Nov 2016 18:45:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.20.1611161845050.26593@digraph.polyomino.org.uk> (raw)
In-Reply-To: <20161116053145.GM21655@vapier.lan>
On Tue, 15 Nov 2016, Mike Frysinger wrote:
> On 04 Nov 2016 21:37, Joseph Myers wrote:
> > nios2 glibc compile-only test results include:
> >
> > FAIL: misc/check-installed-headers-c
> > FAIL: misc/check-installed-headers-cxx
> >
> > This is because sys/cachectl.h includes asm/cachectl.h, and the Linux
> > kernel has no such header. How is this meant to work? Should that
> > #include just be removed?
>
> delete it for now. looks like they speced it out for future usage,
> but haven't yet gotten around to it. the kernel will explicitly
> throw an error if the |op| field is non-zero.
This patch does that.
Do not include asm/cachectl.h in nios2 sys/cachectl.h.
The nios2 sys/cachectl.h includes a kernel header asm/cachectl.h,
which does not exist, so causing the check-installed-headers tests to
fail. This patch removes the include of a nonexistent header.
Tested (compilation only) for nios2.
2016-11-16 Joseph Myers <joseph@codesourcery.com>
* sysdeps/unix/sysv/linux/nios2/sys/cachectl.h: Do not include
<asm/cachectl.h>.
diff --git a/sysdeps/unix/sysv/linux/nios2/sys/cachectl.h b/sysdeps/unix/sysv/linux/nios2/sys/cachectl.h
index 717e6ae..d4e6b2e 100644
--- a/sysdeps/unix/sysv/linux/nios2/sys/cachectl.h
+++ b/sysdeps/unix/sysv/linux/nios2/sys/cachectl.h
@@ -21,9 +21,6 @@
#include <features.h>
-/* Get the kernel definition for the op bits. */
-#include <asm/cachectl.h>
-
__BEGIN_DECLS
#ifdef __USE_MISC
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2016-11-16 18:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-04 21:37 Joseph Myers
2016-11-16 5:31 ` Mike Frysinger
2016-11-16 18:45 ` Joseph Myers [this message]
2016-11-21 16:48 ` Ping " Joseph Myers
2016-11-27 7:14 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1611161845050.26593@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=cltang@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).