public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Joseph Myers <joseph@codesourcery.com>
To: Zack Weinberg <zackw@panix.com>
Cc: <libc-alpha@sourceware.org>
Subject: Re: Add script to build many glibc configurations
Date: Thu, 17 Nov 2016 17:47:00 -0000	[thread overview]
Message-ID: <alpine.DEB.2.20.1611171746140.21214@digraph.polyomino.org.uk> (raw)
In-Reply-To: <f65de905-83ae-39f7-3541-60255081c02f@panix.com>

On Thu, 17 Nov 2016, Zack Weinberg wrote:

> On 11/17/2016 11:52 AM, Zack Weinberg wrote:
> > On 11/09/2016 11:27 AM, Joseph Myers wrote:
> >> This patch adds a Python (3.5 or later) script to build many different
> >> configurations of glibc, including building the required cross
> >> compilers first.  It's not intended to change any patch testing
> >> requirements, although some people may wish to use it for high-risk
> >> patches such as adding warning options ...
> > 
> > Since this does its own glibc checkout, it's not clear to me how one
> > should use it to test a patch(set).  I presume that whatever one does,
> > it only affects the "glibcs" step, but what actually do you do?  Do you
> > manually update /some/where/src/glibc to contain the code you want
> > tested and then run "glibcs", or do you somehow tell
> > build-many-glibcs.py the name of a branch you want tested, or what?
> 
> I went ahead with the setup steps, and they failed during the compilers
> phase.  It seems that it's not picking up the host libraries I just
> built.  Now what?

I've committed this patch to fix this.  (The systems I tested on had 
suitable versions of these libraries installed where host GCC could find 
them, so I didn't notice that the newly built libraries weren't being 
used.)

Actually use newly built host libraries in build-many-glibcs.py.

This patch adds the missing GCC configure options required to make use
of the newly built host libraries in build-many-glibcs.py.

2016-11-17  Joseph Myers  <joseph@codesourcery.com>

	* scripts/build-many-glibcs.py (Config.build_gcc): Configure with
	newly built gmp, mpfr and mpc.

diff --git a/scripts/build-many-glibcs.py b/scripts/build-many-glibcs.py
index be561c3..b0e0f5e 100755
--- a/scripts/build-many-glibcs.py
+++ b/scripts/build-many-glibcs.py
@@ -813,6 +813,10 @@ class Config(object):
         # relevance with glibc's own stack checking support.
         cfg_opts = list(self.gcc_cfg)
         cfg_opts += ['--disable-libsanitizer', '--disable-libssp']
+        host_libs = self.ctx.host_libraries_installdir
+        cfg_opts += ['--with-gmp=%s' % host_libs,
+                     '--with-mpfr=%s' % host_libs,
+                     '--with-mpc=%s' % host_libs]
         if bootstrap:
             tool_build = 'gcc-first'
             # Building a static-only, C-only compiler that is

-- 
Joseph S. Myers
joseph@codesourcery.com

  reply	other threads:[~2016-11-17 17:47 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-09 16:27 Joseph Myers
2016-11-10 14:27 ` Joseph Myers
2016-11-10 16:44   ` Joseph Myers
2016-11-23 17:36   ` Chris Metcalf
2016-11-10 17:09 ` Steve Ellcey
2016-11-10 17:22   ` Joseph Myers
2016-11-10 17:39     ` Steve Ellcey
2016-11-11 15:20 ` Joseph Myers
2016-11-11 19:37   ` Carlos O'Donell
2016-11-14 15:06   ` Mike Frysinger
2016-11-14 15:23     ` Joseph Myers
2016-11-14 19:27       ` Mike Frysinger
2016-11-14 23:28         ` Joseph Myers
2016-11-14 23:57     ` Joseph Myers
2016-11-17 16:52 ` Zack Weinberg
2016-11-17 17:26   ` Zack Weinberg
2016-11-17 17:47     ` Joseph Myers [this message]
2016-11-17 17:54     ` Andreas Schwab
2016-11-17 17:51   ` Joseph Myers
2016-11-18 16:28     ` Zack Weinberg
2016-11-18 18:27       ` Joseph Myers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1611171746140.21214@digraph.polyomino.org.uk \
    --to=joseph@codesourcery.com \
    --cc=libc-alpha@sourceware.org \
    --cc=zackw@panix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).