From: Mike Frysinger <vapier@gentoo.org>
To: Joseph Myers <joseph@codesourcery.com>
Cc: libc-alpha@sourceware.org
Subject: Re: Add script to build many glibc configurations
Date: Mon, 14 Nov 2016 15:06:00 -0000 [thread overview]
Message-ID: <20161114150603.GT21655@vapier.lan> (raw)
In-Reply-To: <alpine.DEB.2.20.1611111519220.30336@digraph.polyomino.org.uk>
[-- Attachment #1: Type: text/plain, Size: 600 bytes --]
On 11 Nov 2016 15:20, Joseph Myers wrote:
> +import os.path
this import is unnecessary
> +class Context:
please no old style classes. all of them should inherit object.
class Context(object):
> +
> + """The global state associated with builds in a given directory."""
don't put a blank line between the class and its docstring.
> + os.chmod(self.wrapper,
> + (stat.S_IRWXU|stat.S_IRGRP|stat.S_IXGRP|
> + stat.S_IROTH|stat.S_IXOTH))
the stat constants are unreadable imo. better to never use them and
stick to sane octals like 0644 and such.
-mike
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-11-14 15:06 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-09 16:27 Joseph Myers
2016-11-10 14:27 ` Joseph Myers
2016-11-10 16:44 ` Joseph Myers
2016-11-23 17:36 ` Chris Metcalf
2016-11-10 17:09 ` Steve Ellcey
2016-11-10 17:22 ` Joseph Myers
2016-11-10 17:39 ` Steve Ellcey
2016-11-11 15:20 ` Joseph Myers
2016-11-11 19:37 ` Carlos O'Donell
2016-11-14 15:06 ` Mike Frysinger [this message]
2016-11-14 15:23 ` Joseph Myers
2016-11-14 19:27 ` Mike Frysinger
2016-11-14 23:28 ` Joseph Myers
2016-11-14 23:57 ` Joseph Myers
2016-11-17 16:52 ` Zack Weinberg
2016-11-17 17:26 ` Zack Weinberg
2016-11-17 17:47 ` Joseph Myers
2016-11-17 17:54 ` Andreas Schwab
2016-11-17 17:51 ` Joseph Myers
2016-11-18 16:28 ` Zack Weinberg
2016-11-18 18:27 ` Joseph Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161114150603.GT21655@vapier.lan \
--to=vapier@gentoo.org \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).