* Fix signal.h bsd_signal namespace (bug 21445)
@ 2017-04-28 17:17 Joseph Myers
2017-05-04 13:47 ` Ping " Joseph Myers
0 siblings, 1 reply; 3+ messages in thread
From: Joseph Myers @ 2017-04-28 17:17 UTC (permalink / raw)
To: libc-alpha
signal.h declares bsd_signal for __USE_XOPEN. But this function was
obsoleted in the 2001 edition of POSIX and removed in the 2008
edition, so it should not be declared when the 2008 edition is in use.
This patch fixes the conditionals accordingly. (This does not fix any
conform/ test failures because of other namespace issues in signal.h.)
Tested for x86_64.
2017-04-28 Joseph Myers <joseph@codesourcery.com>
[BZ #21445]
* signal/signal.h [__USE_XOPEN2K8] (bsd_signal): Do not declare.
diff --git a/signal/signal.h b/signal/signal.h
index 84f2a1f..6db2d2f 100644
--- a/signal/signal.h
+++ b/signal/signal.h
@@ -108,7 +108,7 @@ extern __sighandler_t __REDIRECT_NTH (signal,
# endif
#endif
-#ifdef __USE_XOPEN
+#if defined __USE_XOPEN && !defined __USE_XOPEN2K8
/* The X/Open definition of `signal' conflicts with the BSD version.
So they defined another function `bsd_signal'. */
extern __sighandler_t bsd_signal (int __sig, __sighandler_t __handler)
--
Joseph S. Myers
joseph@codesourcery.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Ping Re: Fix signal.h bsd_signal namespace (bug 21445)
2017-04-28 17:17 Fix signal.h bsd_signal namespace (bug 21445) Joseph Myers
@ 2017-05-04 13:47 ` Joseph Myers
2017-05-04 17:31 ` Adhemerval Zanella
0 siblings, 1 reply; 3+ messages in thread
From: Joseph Myers @ 2017-05-04 13:47 UTC (permalink / raw)
To: libc-alpha
Ping. This patch
<https://sourceware.org/ml/libc-alpha/2017-04/msg00576.html> is pending
review.
--
Joseph S. Myers
joseph@codesourcery.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Ping Re: Fix signal.h bsd_signal namespace (bug 21445)
2017-05-04 13:47 ` Ping " Joseph Myers
@ 2017-05-04 17:31 ` Adhemerval Zanella
0 siblings, 0 replies; 3+ messages in thread
From: Adhemerval Zanella @ 2017-05-04 17:31 UTC (permalink / raw)
To: libc-alpha
On 04/05/2017 10:47, Joseph Myers wrote:
> Ping. This patch
> <https://sourceware.org/ml/libc-alpha/2017-04/msg00576.html> is pending
> review.
>
LGTM, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-05-04 17:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-28 17:17 Fix signal.h bsd_signal namespace (bug 21445) Joseph Myers
2017-05-04 13:47 ` Ping " Joseph Myers
2017-05-04 17:31 ` Adhemerval Zanella
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).