From: Joseph Myers <joseph@codesourcery.com>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>
Cc: <libc-alpha@sourceware.org>
Subject: Re: [hurd,commited] hurd: Replace threadvars with TLS
Date: Mon, 19 Mar 2018 16:43:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.20.1803191641540.4537@digraph.polyomino.org.uk> (raw)
In-Reply-To: <20180317223049.11865-1-samuel.thibault@ens-lyon.org>
On Sat, 17 Mar 2018, Samuel Thibault wrote:
> diff --git a/sysdeps/mach/hurd/errno-loc.c b/sysdeps/mach/hurd/errno-loc.c
> index 7b1e7ce347..95d0fe47c4 100644
> --- a/sysdeps/mach/hurd/errno-loc.c
> +++ b/sysdeps/mach/hurd/errno-loc.c
> @@ -16,13 +16,21 @@
> License along with the GNU C Library; if not, see
> <http://www.gnu.org/licenses/>. */
>
> -#include <errno.h>
> -#include <hurd/threadvar.h>
> -
> -int *
> +#if IS_IN (rtld)
> +/*
> + * rtld can not access TLS too early, thus rtld_errno.
> + *
> + * Instead of making __open/__close pass errno from TLS to rtld_errno, simply
> + * use a weak __errno_location using rtld_errno, which will be overriden by the
> + * libc definition.
> + */
We don't use leading '*' on each line of comments.
--
Joseph S. Myers
joseph@codesourcery.com
prev parent reply other threads:[~2018-03-19 16:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-17 22:31 Samuel Thibault
2018-03-19 16:43 ` Joseph Myers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1803191641540.4537@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=samuel.thibault@ens-lyon.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).