From: Joseph Myers <joseph@codesourcery.com>
To: Stefan Liebler <stli@linux.ibm.com>
Cc: <libc-alpha@sourceware.org>
Subject: Re: [PATCH] S390: Don't test nanoseconds in io/tst-stat.c
Date: Wed, 17 Mar 2021 21:01:08 +0000 [thread overview]
Message-ID: <alpine.DEB.2.22.394.2103172058590.139917@digraph.polyomino.org.uk> (raw)
In-Reply-To: <20210317130352.1782897-1-stli@linux.ibm.com>
On Wed, 17 Mar 2021, Stefan Liebler via Libc-alpha wrote:
> Both new tests io/tst-stat and io/tst-stat-lfs (_FILE_OFFSET_BITS=64)
> are comparing the nanosecond fields with the statx result. Unfortunately
> on s390(31bit) those fields are always zero if old KABI with non-LFS
> support is used. With _FILE_OFFSET_BITS=64 stat is using statx internally.
My understanding is that, if using a kernel that supports statx, this
disabling is not needed.
If so, we want to be sure to remove this disabling once we can assume a
kernel supporting statx (on s390). The way we ensure that is having a
conditional on __ASSUME_STATX in the code in question so that it's
immediately visible when we remove __ASSUME_STATX that this disabling can
be removed from the glibc source code as well.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2021-03-17 21:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 13:03 Stefan Liebler
2021-03-17 21:01 ` Joseph Myers [this message]
2021-03-17 21:20 ` Adhemerval Zanella
2021-03-18 13:31 ` Adhemerval Zanella
2021-03-23 16:13 ` Stefan Liebler
2021-03-24 17:40 ` Adhemerval Zanella
2021-03-26 9:24 ` Stefan Liebler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2103172058590.139917@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=stli@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).