public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
* Add ARPHRD_CAN, ARPHRD_MCTP to net/if_arp.h
@ 2021-12-09 21:42 Joseph Myers
  2021-12-16 21:57 ` Ping " Joseph Myers
  2021-12-17 11:56 ` Florian Weimer
  0 siblings, 2 replies; 3+ messages in thread
From: Joseph Myers @ 2021-12-09 21:42 UTC (permalink / raw)
  To: libc-alpha

Add the constant ARPHRD_MCTP, from Linux 5.15, to net/if_arp.h, along
with ARPHRD_CAN which was added to Linux in version 2.6.25 (commit
cd05acfe65ed2cf2db683fa9a6adb8d35635263b, "[CAN]: Allocate protocol
numbers for PF_CAN") but apparently missed for glibc at the time.

Tested for x86_64.

diff --git a/sysdeps/unix/sysv/linux/net/if_arp.h b/sysdeps/unix/sysv/linux/net/if_arp.h
index 0f925da4f4..9ad10c37fa 100644
--- a/sysdeps/unix/sysv/linux/net/if_arp.h
+++ b/sysdeps/unix/sysv/linux/net/if_arp.h
@@ -94,6 +94,8 @@ struct arphdr
 #define ARPHRD_ROSE	270
 #define ARPHRD_X25	271		/* CCITT X.25.  */
 #define ARPHRD_HWX25	272		/* Boards with X.25 in firmware.  */
+#define ARPHRD_CAN	280		/* Controller Area Network.  */
+#define ARPHRD_MCTP	290
 #define ARPHRD_PPP	512
 #define ARPHRD_CISCO	513		/* Cisco HDLC.  */
 #define ARPHRD_HDLC	ARPHRD_CISCO

-- 
Joseph S. Myers
joseph@codesourcery.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Ping Re: Add ARPHRD_CAN, ARPHRD_MCTP to net/if_arp.h
  2021-12-09 21:42 Add ARPHRD_CAN, ARPHRD_MCTP to net/if_arp.h Joseph Myers
@ 2021-12-16 21:57 ` Joseph Myers
  2021-12-17 11:56 ` Florian Weimer
  1 sibling, 0 replies; 3+ messages in thread
From: Joseph Myers @ 2021-12-16 21:57 UTC (permalink / raw)
  To: libc-alpha

Ping.  This patch 
<https://sourceware.org/pipermail/libc-alpha/2021-December/133936.html> is 
pending review.

-- 
Joseph S. Myers
joseph@codesourcery.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Add ARPHRD_CAN, ARPHRD_MCTP to net/if_arp.h
  2021-12-09 21:42 Add ARPHRD_CAN, ARPHRD_MCTP to net/if_arp.h Joseph Myers
  2021-12-16 21:57 ` Ping " Joseph Myers
@ 2021-12-17 11:56 ` Florian Weimer
  1 sibling, 0 replies; 3+ messages in thread
From: Florian Weimer @ 2021-12-17 11:56 UTC (permalink / raw)
  To: Joseph Myers; +Cc: libc-alpha

* Joseph Myers:

> Add the constant ARPHRD_MCTP, from Linux 5.15, to net/if_arp.h, along
> with ARPHRD_CAN which was added to Linux in version 2.6.25 (commit
> cd05acfe65ed2cf2db683fa9a6adb8d35635263b, "[CAN]: Allocate protocol
> numbers for PF_CAN") but apparently missed for glibc at the time.
>
> Tested for x86_64.
>
> diff --git a/sysdeps/unix/sysv/linux/net/if_arp.h b/sysdeps/unix/sysv/linux/net/if_arp.h
> index 0f925da4f4..9ad10c37fa 100644
> --- a/sysdeps/unix/sysv/linux/net/if_arp.h
> +++ b/sysdeps/unix/sysv/linux/net/if_arp.h
> @@ -94,6 +94,8 @@ struct arphdr
>  #define ARPHRD_ROSE	270
>  #define ARPHRD_X25	271		/* CCITT X.25.  */
>  #define ARPHRD_HWX25	272		/* Boards with X.25 in firmware.  */
> +#define ARPHRD_CAN	280		/* Controller Area Network.  */
> +#define ARPHRD_MCTP	290
>  #define ARPHRD_PPP	512
>  #define ARPHRD_CISCO	513		/* Cisco HDLC.  */
>  #define ARPHRD_HDLC	ARPHRD_CISCO

This change matches the UAPI header.

Reviewed-by: Florian Weimer <fweimer@redhat.com>

Thanks,
Florian


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-12-17 11:56 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-09 21:42 Add ARPHRD_CAN, ARPHRD_MCTP to net/if_arp.h Joseph Myers
2021-12-16 21:57 ` Ping " Joseph Myers
2021-12-17 11:56 ` Florian Weimer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).