From: Joseph Myers <joseph@codesourcery.com>
To: Stefan Liebler <stli@linux.ibm.com>
Cc: Florian Weimer <fweimer@redhat.com>, <libc-alpha@sourceware.org>
Subject: Re: [PATCH 7/7] s390x: Use <gcc-macros.h> in early HWCAP check
Date: Tue, 18 Jan 2022 21:03:04 +0000 [thread overview]
Message-ID: <alpine.DEB.2.22.394.2201182101540.554435@digraph.polyomino.org.uk> (raw)
In-Reply-To: <b7a1de86-d840-5b3e-60c0-1f1bb51cb6e5@linux.ibm.com>
The "elf: Move _dl_setup_hash to its own file" change (commit
c90363403b57b3b7919061851cb3e6d9c85e784a) appears to have broken the build
for MIPS (all ABIs).
In file included from ../sysdeps/gnu/ldsodefs.h:46,
from ../sysdeps/unix/sysv/linux/ldsodefs.h:25,
from ../sysdeps/unix/sysv/linux/mips/ldsodefs.h:22,
from dl-setup_hash.c:21:
dl-setup_hash.c: In function '_dl_setup_hash':
../sysdeps/mips/ldsodefs.h:39:33: error: implicit declaration of function 'DT_MIPS'; did you mean 'EM_MIPS'? [-Werror=implicit-function-declaration]
39 | (hash32) += (map)->l_info[DT_MIPS (SYMTABNO)]->d_un.d_val - (symbias); \
| ^~~~~~~
dl-setup_hash.c:48:7: note: in expansion of macro 'ELF_MACHINE_XHASH_SETUP'
48 | ELF_MACHINE_XHASH_SETUP (hash32, symbias, map);
| ^~~~~~~~~~~~~~~~~~~~~~~
../sysdeps/mips/ldsodefs.h:39:42: error: 'SYMTABNO' undeclared (first use in this function)
39 | (hash32) += (map)->l_info[DT_MIPS (SYMTABNO)]->d_un.d_val - (symbias); \
| ^~~~~~~~
dl-setup_hash.c:48:7: note: in expansion of macro 'ELF_MACHINE_XHASH_SETUP'
48 | ELF_MACHINE_XHASH_SETUP (hash32, symbias, map);
| ^~~~~~~~~~~~~~~~~~~~~~~
../sysdeps/mips/ldsodefs.h:39:42: note: each undeclared identifier is reported only once for each function it appears in
39 | (hash32) += (map)->l_info[DT_MIPS (SYMTABNO)]->d_un.d_val - (symbias); \
| ^~~~~~~~
dl-setup_hash.c:48:7: note: in expansion of macro 'ELF_MACHINE_XHASH_SETUP'
48 | ELF_MACHINE_XHASH_SETUP (hash32, symbias, map);
| ^~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2022-01-18 21:03 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-14 12:40 [PATCH 0/7] Reliable CPU compatibility diagnostics in ld.so Florian Weimer
2022-01-14 12:40 ` [PATCH 1/7] x86: HAVE_X86_LAHF_SAHF, HAVE_X86_MOVBE and -march=x86-64-vN (bug 28782) Florian Weimer
2022-01-14 14:21 ` H.J. Lu
2022-01-14 12:40 ` [PATCH 2/7] Generate gcc-macros.h Florian Weimer
2022-01-14 14:24 ` H.J. Lu
2022-01-14 12:40 ` [PATCH 3/7] elf: Split dl-printf.c from dl-misc.c Florian Weimer
2022-01-14 14:25 ` H.J. Lu
2022-01-14 14:27 ` Florian Weimer
2022-01-14 14:32 ` H.J. Lu
2022-01-14 12:40 ` [PATCH 4/7] Add --early-cflags configure option Florian Weimer
2022-01-14 14:27 ` H.J. Lu
2022-01-14 14:29 ` Florian Weimer
2022-01-14 14:33 ` H.J. Lu
2022-01-14 14:34 ` Florian Weimer
2022-01-14 12:40 ` [PATCH 5/7] powerpc64le: Use <gcc-macros.h> in early HWCAP check Florian Weimer
2022-01-14 12:41 ` [PATCH 6/7] x86: Add x86-64-vN check to early startup Florian Weimer
2022-01-14 12:41 ` [PATCH 7/7] s390x: Use <gcc-macros.h> in early HWCAP check Florian Weimer
2022-01-18 12:42 ` Stefan Liebler
2022-01-18 12:54 ` Florian Weimer
2022-01-18 13:31 ` Stefan Liebler
2022-01-18 13:33 ` Florian Weimer
2022-01-18 13:38 ` Stefan Liebler
2022-01-18 21:03 ` Joseph Myers [this message]
2022-01-18 21:21 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2201182101540.554435@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=stli@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).