From: Joseph Myers <joseph@codesourcery.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: <libc-alpha@sourceware.org>, Fangrui Song <maskray@google.com>,
"H . J . Lu" <hjl.tools@gmail.com>,
Noah Goldstein <goldstein.w.n@gmail.com>
Subject: Re: [PATCH v2] x86: Remove .tfloat usage
Date: Mon, 3 Oct 2022 16:40:22 +0000 [thread overview]
Message-ID: <alpine.DEB.2.22.394.2210031638120.800658@digraph.polyomino.org.uk> (raw)
In-Reply-To: <20221003141802.281647-1-adhemerval.zanella@linaro.org>
On Mon, 3 Oct 2022, Adhemerval Zanella via Libc-alpha wrote:
> -factor: .tfloat ONE_SQR_CBRT2
> +factor: /* 1.0 / cbrt (2.0) ^ 2 / 0.629960524947436582364439673883 */
The comment here seems to be using "/" in two different ways, as a
division operator and to separate two alternative descriptions of the
constant. I think the latter should be "=", in this and the subsequent
similar comments, to avoid confusion.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2022-10-03 16:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-03 14:18 Adhemerval Zanella
2022-10-03 16:40 ` Joseph Myers [this message]
2022-10-03 17:02 ` Adhemerval Zanella Netto
2022-10-03 21:47 ` Fangrui Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2210031638120.800658@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=adhemerval.zanella@linaro.org \
--cc=goldstein.w.n@gmail.com \
--cc=hjl.tools@gmail.com \
--cc=libc-alpha@sourceware.org \
--cc=maskray@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).