From: Rajalakshmi Srinivasaraghavan <rajis@linux.vnet.ibm.com>
To: Siddhesh Poyarekar <siddhesh@gotplt.org>,
MAHESH BODAPATI <bmahi496@linux.ibm.com>,
libc-alpha@sourceware.org
Cc: rajis@linux.ibm.com, skissane@gmail.com, dj@redhat.com,
Mahesh Bodapati <mahesh.bodapati@ibm.com>,
Adhemerval Zanella <adhemerval.zanella@linaro.org>
Subject: Re: [PATCH v2] Skip mcount overflow and tunables tests on "--disable-tunables"
Date: Wed, 22 Mar 2023 07:56:36 -0500 [thread overview]
Message-ID: <b0d91286-47d1-8789-2326-c17cf028267d@linux.vnet.ibm.com> (raw)
In-Reply-To: <9be49170-44be-547b-399a-7318c0efd076@gotplt.org>
On 3/22/23 6:29 AM, Siddhesh Poyarekar wrote:
> On 2023-03-21 14:33, MAHESH BODAPATI via Libc-alpha wrote:
>> From: Mahesh Bodapati <mahesh.bodapati@ibm.com>
>>
>> Add a have_tunables check on the new tests added in recent commit
>> - "gmon: improve mcount overflow handling [BZ# 27576]"
>> commit ID 31be941e4367c001b2009308839db5c67bf9dcbc
>
> Orthogonal question since you posted this patch to fix a
> --disable-tunables build: are you actually using this configuration or
> is it just part of your testing matrix? We are considering removing
> the ability to disable tunables[1] so if the option is important to
> you, you should chime in there.
Mahesh submitted this patch a few days before Adhemerval submitted the
patch removing the ability to disable tunables. We have a power CI
which tests disable-tunable option and that was the reason for fixing
this. If we are going to remove that ability, I am fine with discarding
this patch.
>
> Thanks,
> Sid
>
> [1] https://sourceware.org/pipermail/libc-alpha/2023-March/146320.html
next prev parent reply other threads:[~2023-03-22 12:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 18:33 MAHESH BODAPATI
2023-03-21 21:48 ` DJ Delorie
2023-03-23 6:04 ` MAHESH BODAPATI
2023-03-22 11:29 ` Siddhesh Poyarekar
2023-03-22 12:56 ` Rajalakshmi Srinivasaraghavan [this message]
2023-03-22 14:29 ` Siddhesh Poyarekar
2023-03-23 6:20 ` MAHESH BODAPATI
2023-03-23 12:19 ` Siddhesh Poyarekar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0d91286-47d1-8789-2326-c17cf028267d@linux.vnet.ibm.com \
--to=rajis@linux.vnet.ibm.com \
--cc=adhemerval.zanella@linaro.org \
--cc=bmahi496@linux.ibm.com \
--cc=dj@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=mahesh.bodapati@ibm.com \
--cc=rajis@linux.ibm.com \
--cc=siddhesh@gotplt.org \
--cc=skissane@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).