From: MAHESH BODAPATI <bmahi496@linux.ibm.com>
To: DJ Delorie <dj@redhat.com>
Cc: libc-alpha@sourceware.org, rajis@linux.ibm.com,
skissane@gmail.com, mahesh.bodapati@ibm.com
Subject: Re: [PATCH v2] Skip mcount overflow and tunables tests on "--disable-tunables"
Date: Thu, 23 Mar 2023 11:34:43 +0530 [thread overview]
Message-ID: <d32a05d3-7201-f2d8-ce02-cebba7103fa8@linux.ibm.com> (raw)
In-Reply-To: <xnpm91zsg5.fsf@greed.delorie.com>
On 22/03/23 3:18 am, DJ Delorie wrote:
> MAHESH BODAPATI <bmahi496@linux.ibm.com> writes:
>> +have-tunables = @have_tunables@
> config.make.in already has one of these.
>
> The rest looks OK, but did you test it with tunables disabled vs enabled?
Yes,I tested the glibc with tunables enabled vs disabled.have_tunables
can't be used in gmon/Makefile so have-tunables variable has been set in
config.make.in
>
>> diff --git a/gmon/Makefile b/gmon/Makefile
>> index 213622a7ad..934a2b230d 100644
>> --- a/gmon/Makefile
>> +++ b/gmon/Makefile
>> @@ -26,7 +26,11 @@ include ../Makeconfig
>> headers := sys/gmon.h sys/gmon_out.h sys/profil.h
>> routines := gmon mcount profil sprofil prof-freq
>>
>> -tests = tst-sprofil tst-gmon tst-mcount-overflow tst-mcleanup
>> +tests = tst-sprofil tst-gmon tst-mcleanup
>> +ifeq ($(have-tunables),yes)
>> +tests += tst-mcount-overflow
>> +endif
>> +
>> ifeq ($(build-profile),yes)
>> tests += tst-profile-static
>> tests-static += tst-profile-static
>> @@ -57,6 +61,7 @@ ifeq ($(run-built-tests),yes)
>> tests-special += $(objpfx)tst-gmon-gprof.out
>> endif
>>
>> +ifeq ($(have-tunables),yes)
>> CFLAGS-tst-mcount-overflow.c := -fno-omit-frame-pointer -pg
>> tst-mcount-overflow-no-pie = yes
>> CRT-tst-mcount-overflow := $(csu-objpfx)g$(start-installed-name)
>> @@ -68,6 +73,7 @@ tst-mcount-overflow-ARGS := 2>&1 1>/dev/null | cat
>> ifeq ($(run-built-tests),yes)
>> tests-special += $(objpfx)tst-mcount-overflow-check.out
>> endif
>> +endif
>>
>> CFLAGS-tst-mcleanup.c := -fno-omit-frame-pointer -pg
>> tst-mcleanup-no-pie = yes
>> @@ -124,6 +130,7 @@ $(objpfx)tst-gmon.out: clean-tst-gmon-data
>> clean-tst-gmon-data:
>> rm -f $(objpfx)tst-gmon.data.*
>>
>> +ifeq ($(have-tunables),yes)
>> $(objpfx)tst-mcount-overflow.o: clean-tst-mcount-overflow-data
>> clean-tst-mcount-overflow-data:
>> rm -f $(objpfx)tst-mcount-overflow.data.*
>> @@ -131,6 +138,7 @@ clean-tst-mcount-overflow-data:
>> $(objpfx)tst-mcount-overflow-check.out: tst-mcount-overflow-check.sh $(objpfx)tst-mcount-overflow.out
>> $(SHELL) $< $(objpfx)tst-mcount-overflow > $@; \
>> $(evaluate-test)
>> +endif
>>
>> $(objpfx)tst-mcleanup.out: clean-tst-mcleanup-data
>> clean-tst-mcleanup-data:
next prev parent reply other threads:[~2023-03-23 6:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 18:33 MAHESH BODAPATI
2023-03-21 21:48 ` DJ Delorie
2023-03-23 6:04 ` MAHESH BODAPATI [this message]
2023-03-22 11:29 ` Siddhesh Poyarekar
2023-03-22 12:56 ` Rajalakshmi Srinivasaraghavan
2023-03-22 14:29 ` Siddhesh Poyarekar
2023-03-23 6:20 ` MAHESH BODAPATI
2023-03-23 12:19 ` Siddhesh Poyarekar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d32a05d3-7201-f2d8-ce02-cebba7103fa8@linux.ibm.com \
--to=bmahi496@linux.ibm.com \
--cc=dj@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=mahesh.bodapati@ibm.com \
--cc=rajis@linux.ibm.com \
--cc=skissane@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).