Re: [PATCH] Makefules: fix MAKEFLAGS assignment for upcoming make-4.4

[Siddhesh Poyarekar <siddhesh@gotplt.org>]

On 2022-09-09 07:50, Sergei Trofimovich via Libc-alpha wrote:
> make-4.4 will add long flags to MAKEFLAGS variable:
> 
>      * WARNING: Backward-incompatibility!
>        Previously only simple (one-letter) options were added to the MAKEFLAGS
>        variable that was visible while parsing makefiles.  Now, all options
>        are available in MAKEFLAGS.
> 
> This causes locale builds to fail when long options are used:
> 
>      $ make --shuffle
>      ...
>      make  -C localedata install-locales
>      make: invalid shuffle mode: '1662724426r'
> 
> The change fixes it by passing eash option via whitespace and dashes.
> That way option is appended to both single-word form and whitespace
> separated form.
> 
> Signed-off-by: Sergei Trofimovich <slyich@gmail.com>
> ---

Thanks, that's the right direction IMO but allowing word form flags will 
break this check too:

     ifeq    "$(findstring s,$(MAKEFLAGS))" ""       # if not -s

which is present in Makerules, Makeconfig and elf/rtld-Rules since the s 
will also match, e.g. --shuffle.  Those checks need to be fixed too.

Thanks,
Siddhesh