From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: "Alejandro Colomar (man-pages)" <alx.manpages@gmail.com>,
libc-alpha@sourceware.org
Subject: Re: [PATCH] stdio-common/printf-prs.c: Simplify test
Date: Mon, 29 Mar 2021 17:43:57 -0300 [thread overview]
Message-ID: <b46d857f-b93d-bb4f-d405-9e8bd4525920@linaro.org> (raw)
In-Reply-To: <4ad8aa37-2efa-3eb5-3c10-455993ef6cb7@gmail.com>
On 29/03/2021 17:35, Alejandro Colomar (man-pages) wrote:
>
>
> On 3/29/21 9:32 PM, Adhemerval Zanella wrote:
>>
>>
>> On 24/03/2021 15:07, Alejandro Colomar via Libc-alpha wrote:
>>> The test was being repeated for all the remaining code in the for loop.
>>> Test once, and 'continue' to next iteration if necessary, so that the
>>> following code can assume that the necessary condition is met.
>>>
>>> Minor changes: fix some mixed tabs & spaces to use spaces only.
>>>
>>> Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com>
>>
>> We do not use SCO, but rather Copyright assignment. And I think we will
>> need to add a testcase for this change, this simple program below shows
>> a complete different result with this patch applied:
>>
>
> Hello Adhemerval,
>
> Yes, I was completely wrong with that patch. I submitted a patch v2
> after that, trying to improve the comments (without the code changes,
> which were wrong) to avoid confusion:
> <https://sourceware.org/pipermail/libc-alpha/2021-March/124359.html>.
Ok, I will review this one and mark this as superseded.
prev parent reply other threads:[~2021-03-29 20:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 18:07 Alejandro Colomar
2021-03-29 19:32 ` Adhemerval Zanella
2021-03-29 20:35 ` Alejandro Colomar (man-pages)
2021-03-29 20:43 ` Adhemerval Zanella [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b46d857f-b93d-bb4f-d405-9e8bd4525920@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=alx.manpages@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).