Re: [PATCH v3] Add configure check for python program

Re: [PATCH v3] Add configure check for python program

[Steve Ellcey]

On Thu, 2016-12-22 at 08:07 +0530, Siddhesh Poyarekar wrote:
> Add a configure check that looks for python3 and python in that order
> since we had agreed in the past to prefer python3 over python in all
> our code.  The patch also adjusts invocations through the various
> Makefiles to use the set variable.
> 
> Changes:
> 
>  - Added tests-printers to tests-unsupported instead of removing
> them.
> 
> 	* configure.ac: Check for python3 or python.
> 	* configure: Regenerated.
> 	* config.make.in (PYTHON): New variable.
> 	* benchtests/Makefile: Don't define PYTHON.
> 	(bench): Define target only if PYTHON was defined.
> 	* Rules: Don't define PYTHON.
> 	Define pretty printer targets only if PYTHON was defined.
> 	(tests-printers): Add to tests-unsupported if PYTHON is not
> 	found.
> 	(python-flags, python-invoke): Remove.
> 	(tests-printers-out): Use PYTHON instead of python-invoke.

Yes, I like this version better.  It worked fine on my machine.

Steve Ellcey
sellcey@caviumnetworks.com

Re: [PATCH v3] Add configure check for python program

[Siddhesh Poyarekar]

On Thursday 22 December 2016 10:54 PM, Steve Ellcey wrote:
> On Thu, 2016-12-22 at 08:07 +0530, Siddhesh Poyarekar wrote:
>> Add a configure check that looks for python3 and python in that order
>> since we had agreed in the past to prefer python3 over python in all
>> our code.  The patch also adjusts invocations through the various
>> Makefiles to use the set variable.
>>
>> Changes:
>>
>>  - Added tests-printers to tests-unsupported instead of removing
>> them.
>>
>> 	* configure.ac: Check for python3 or python.
>> 	* configure: Regenerated.
>> 	* config.make.in (PYTHON): New variable.
>> 	* benchtests/Makefile: Don't define PYTHON.
>> 	(bench): Define target only if PYTHON was defined.
>> 	* Rules: Don't define PYTHON.
>> 	Define pretty printer targets only if PYTHON was defined.
>> 	(tests-printers): Add to tests-unsupported if PYTHON is not
>> 	found.
>> 	(python-flags, python-invoke): Remove.
>> 	(tests-printers-out): Use PYTHON instead of python-invoke.
> 
> Yes, I like this version better.  It worked fine on my machine.

Thanks, I've pushed it to master.

Siddhesh

Re: [PATCH v3] Add configure check for python program

[Joseph Myers]

This has caused "make check" in a run-built-tests=no cross-compilation 
environment (with build-many-glibcs.py) to fail with:

make[3]: *** No rule to make target '/scratch/jmyers/glibc-bot/build/glibcs/aarch64-linux-gnu/glibc/nptl//scratch/jmyers/glibc-bot/build/glibcs/aarch64-linux-gnu/glibc/nptl/test-mutexattr-printers', needed by 'tests'.  Stop.

https://sourceware.org/ml/libc-testresults/2016-q4/msg00062.html

(Commit 8ce8299f9458c7fee8554ecd4b97cc5eddba4e4c is the only change 
between this and the previous build that worked.)

-- 
Joseph S. Myers
joseph@codesourcery.com

Re: [PATCH v3] Add configure check for python program

[Siddhesh Poyarekar]

On Friday 23 December 2016 04:52 AM, Joseph Myers wrote:
> This has caused "make check" in a run-built-tests=no cross-compilation 
> environment (with build-many-glibcs.py) to fail with:
> 
> make[3]: *** No rule to make target '/scratch/jmyers/glibc-bot/build/glibcs/aarch64-linux-gnu/glibc/nptl//scratch/jmyers/glibc-bot/build/glibcs/aarch64-linux-gnu/glibc/nptl/test-mutexattr-printers', needed by 'tests'.  Stop.
> 
> https://sourceware.org/ml/libc-testresults/2016-q4/msg00062.html
> 
> (Commit 8ce8299f9458c7fee8554ecd4b97cc5eddba4e4c is the only change 
> between this and the previous build that worked.)

Sorry, I didn't notice this early.  I'll write a fix for this tonight.

Siddhesh