From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Joseph Myers <joseph@codesourcery.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH 01/15] linux: Add pidfd_open
Date: Fri, 4 Feb 2022 16:59:30 -0300 [thread overview]
Message-ID: <b871131b-8339-a0c9-d391-64c9f3a3a083@linaro.org> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2202041944180.244210@digraph.polyomino.org.uk>
On 04/02/2022 16:46, Joseph Myers wrote:
> On Thu, 3 Feb 2022, Adhemerval Zanella via Libc-alpha wrote:
>
>> + sys.exit(glibcextract.compare_macro_consts(
>> + '#include <sys/pidfd.h>\n',
>> + '#include <asm/fcntl.h>\n'
>> + '#include <linux/pidfd.h>\n',
>> + args.cc,
>> + 'PIDFD_.*'))
>
> Are you sure about doing this sort of comparison without the kind of
> kernel version checks done in tst-mman-consts.py? That's only OK if (a)
> all the compared macros are present in the oldest kernel headers version
> supported for building glibc and (b) no matching macros will be added in
> any future kernel version.
>
Right, I think it would be good to add such check since neither (a) or
(b) might hold true.
next prev parent reply other threads:[~2022-02-04 19:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-03 17:46 [PATCH 00/15] linux: Add new syscalls Adhemerval Zanella
2022-02-03 17:46 ` [PATCH 01/15] linux: Add pidfd_open Adhemerval Zanella
2022-02-04 19:46 ` Joseph Myers
2022-02-04 19:59 ` Adhemerval Zanella [this message]
2022-02-03 17:46 ` [PATCH 02/15] linux: Add pidfd_getfd Adhemerval Zanella
2022-02-03 17:46 ` [PATCH 03/15] linux: Add pidfd_send_signal Adhemerval Zanella
2022-02-03 17:46 ` [PATCH 04/15] linux: Add P_PIDFD Adhemerval Zanella
2022-02-03 17:46 ` [PATCH 05/15] linux: Add tst-pidfd.c Adhemerval Zanella
2022-02-03 17:46 ` [PATCH 06/15] linux: Add process_madvise Adhemerval Zanella
2022-02-03 17:46 ` [PATCH 07/15] linux: Add process_mrelease Adhemerval Zanella
2022-02-03 17:46 ` [PATCH 08/15] linux: Add fsopen Adhemerval Zanella
2022-02-04 19:48 ` Joseph Myers
2022-02-03 17:46 ` [PATCH 09/15] linux: Add fsmount Adhemerval Zanella
2022-02-03 17:46 ` [PATCH 10/15] linux: Add move_mount Adhemerval Zanella
2022-02-03 17:46 ` [PATCH 11/15] linux: Add fsconfig Adhemerval Zanella
2022-02-03 17:46 ` [PATCH 12/15] linux: Add fspick Adhemerval Zanella
2022-02-03 17:46 ` [PATCH 13/15] linux: Add open_tree Adhemerval Zanella
2022-02-03 17:46 ` [PATCH 14/15] linux: Add tst-mount to check for Linux new mount API Adhemerval Zanella
2022-02-03 17:46 ` [PATCH 15/15] linux: Add mount_setattr Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b871131b-8339-a0c9-d391-64c9f3a3a083@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).