public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] gethostid: Do not include alloca.h
@ 2023-04-24 19:30 Joe Simmons-Talbott
  2023-04-25 14:33 ` Siddhesh Poyarekar
  0 siblings, 1 reply; 2+ messages in thread
From: Joe Simmons-Talbott @ 2023-04-24 19:30 UTC (permalink / raw)
  To: libc-alpha; +Cc: Joe Simmons-Talbott

Nothing from alloca.h is being used here.
---
 sysdeps/unix/sysv/linux/gethostid.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/sysdeps/unix/sysv/linux/gethostid.c b/sysdeps/unix/sysv/linux/gethostid.c
index e717d6a27e..c8d3361d34 100644
--- a/sysdeps/unix/sysv/linux/gethostid.c
+++ b/sysdeps/unix/sysv/linux/gethostid.c
@@ -15,7 +15,6 @@
    License along with the GNU C Library; if not, see
    <https://www.gnu.org/licenses/>.  */
 
-#include <alloca.h>
 #include <errno.h>
 #include <fcntl.h>
 #include <unistd.h>
-- 
2.39.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] gethostid: Do not include alloca.h
  2023-04-24 19:30 [PATCH] gethostid: Do not include alloca.h Joe Simmons-Talbott
@ 2023-04-25 14:33 ` Siddhesh Poyarekar
  0 siblings, 0 replies; 2+ messages in thread
From: Siddhesh Poyarekar @ 2023-04-25 14:33 UTC (permalink / raw)
  To: Joe Simmons-Talbott, libc-alpha

On 2023-04-24 15:30, Joe Simmons-Talbott via Libc-alpha wrote:
> Nothing from alloca.h is being used here.
> ---

LGTM.

Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>

>   sysdeps/unix/sysv/linux/gethostid.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/sysdeps/unix/sysv/linux/gethostid.c b/sysdeps/unix/sysv/linux/gethostid.c
> index e717d6a27e..c8d3361d34 100644
> --- a/sysdeps/unix/sysv/linux/gethostid.c
> +++ b/sysdeps/unix/sysv/linux/gethostid.c
> @@ -15,7 +15,6 @@
>      License along with the GNU C Library; if not, see
>      <https://www.gnu.org/licenses/>.  */
>   
> -#include <alloca.h>
>   #include <errno.h>
>   #include <fcntl.h>
>   #include <unistd.h>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-04-25 14:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-24 19:30 [PATCH] gethostid: Do not include alloca.h Joe Simmons-Talbott
2023-04-25 14:33 ` Siddhesh Poyarekar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).