* [PATCH] elf: Fix _dl_close_worker compile error with -Werror and -DNDEBUG
[not found] <d81db43e-eae7-ed10-b03b-887b4eb432e5@huawei.com>
@ 2023-09-15 7:21 ` Qingqing Li
2023-09-19 13:52 ` Adhemerval Zanella Netto
0 siblings, 1 reply; 2+ messages in thread
From: Qingqing Li @ 2023-09-15 7:21 UTC (permalink / raw)
To: libc-alpha, fweimer, carlos; +Cc: Yang Yanchao, linfeilong, louhongxiang
here is the error:
dl-close.c: In function ‘_dl_close_worker’:
dl-close.c:140:22: error: unused variable ‘nloaded’ [-Werror=unused-variable]
140 | const unsigned int nloaded = ns->_ns_nloaded;
---
elf/dl-close.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/elf/dl-close.c b/elf/dl-close.c
index c9a7d06577..a0bddb583d 100644
--- a/elf/dl-close.c
+++ b/elf/dl-close.c
@@ -137,7 +137,7 @@ _dl_close_worker (struct link_map *map, bool force)
dl_close_state = pending;
bool any_tls = false;
- const unsigned int nloaded = ns->_ns_nloaded;
+ __attribute__ ((unused)) const unsigned int nloaded = ns->_ns_nloaded;
/* Run over the list and assign indexes to the link maps. */
int idx = 0;
--
2.27.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] elf: Fix _dl_close_worker compile error with -Werror and -DNDEBUG
2023-09-15 7:21 ` [PATCH] elf: Fix _dl_close_worker compile error with -Werror and -DNDEBUG Qingqing Li
@ 2023-09-19 13:52 ` Adhemerval Zanella Netto
0 siblings, 0 replies; 2+ messages in thread
From: Adhemerval Zanella Netto @ 2023-09-19 13:52 UTC (permalink / raw)
To: Qingqing Li, libc-alpha, fweimer, carlos
Cc: Yang Yanchao, linfeilong, louhongxiang
On 15/09/23 04:21, Qingqing Li wrote:
> here is the error:
> dl-close.c: In function ‘_dl_close_worker’:
> dl-close.c:140:22: error: unused variable ‘nloaded’ [-Werror=unused-variable]
> 140 | const unsigned int nloaded = ns->_ns_nloaded;
Please add that this failure happens with -DNDEBUG on commit message
and also reference the bug 18755 on title (it is closed, but it is
good to track the build failures with -DNDEBUG).
> ---
> elf/dl-close.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/elf/dl-close.c b/elf/dl-close.c
> index c9a7d06577..a0bddb583d 100644
> --- a/elf/dl-close.c
> +++ b/elf/dl-close.c
> @@ -137,7 +137,7 @@ _dl_close_worker (struct link_map *map, bool force)
> dl_close_state = pending;
>
> bool any_tls = false;
> - const unsigned int nloaded = ns->_ns_nloaded;
> + __attribute__ ((unused)) const unsigned int nloaded = ns->_ns_nloaded;
We already have __attribute_maybe_unused__ and usually attribute are
added after variable definition:
const unsigned int nloaded __attribute_maybe_unused__ = ns->_ns_nloaded;
>
> /* Run over the list and assign indexes to the link maps. */
> int idx = 0;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-09-19 13:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <d81db43e-eae7-ed10-b03b-887b4eb432e5@huawei.com>
2023-09-15 7:21 ` [PATCH] elf: Fix _dl_close_worker compile error with -Werror and -DNDEBUG Qingqing Li
2023-09-19 13:52 ` Adhemerval Zanella Netto
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).