From: Paul Eggert <eggert@cs.ucla.edu>
To: Joseph Myers <joseph@codesourcery.com>, libc-alpha@sourceware.org
Subject: Re: Fix signed integer overflow in random_r (bug 17343)
Date: Sat, 17 Mar 2018 00:26:00 -0000 [thread overview]
Message-ID: <be4d13fb-ba70-681d-63ce-ba2bed6ead68@cs.ucla.edu> (raw)
In-Reply-To: <alpine.DEB.2.20.1803161732060.20069@digraph.polyomino.org.uk>
Joseph Myers wrote:
> int32_t val = state[0];
> - val = ((state[0] * 1103515245) + 12345) & 0x7fffffff;
> + val = ((state[0] * 1103515245U) + 12345U) & 0x7fffffff;
The first assignment to VAL (in the unchanged line) is unnecessary; I suggest
coalescing the two lines.
next prev parent reply other threads:[~2018-03-17 0:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-16 17:33 Joseph Myers
2018-03-17 0:26 ` Paul Eggert [this message]
2018-03-20 17:54 ` Joseph Myers
2018-03-20 17:58 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be4d13fb-ba70-681d-63ce-ba2bed6ead68@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).