Re: [PATCH v4 08/13] LoongArch: Linux Syscall Interface

[Adhemerval Zanella <adhemerval.zanella@linaro.org>]

On 11/05/2022 04:02, Arnd Bergmann wrote:
> On Mon, May 9, 2022 at 4:26 AM caiyinyu <caiyinyu@loongson.cn> wrote:
> 
>> +#define __NR_clone 220
>> +#define __NR_clone3 435
> 
>> +#define __NR_fstat 80
>> +#define __NR_newfstatat 79
> 
> stat() and newfstatat() are not in the current ABI for the kernel, this needs
> to be updated, and the libc wrapper updated to call statx() instead.

Assuming a minimal kernel version for loongarch higher than 4.11 (where glibc
assumes statx support), these stat definitions does not matter.  The
sysdeps/unix/sysv/linux/fstatat64.c (which will be the only use since the
port will be LFS as default) will always call fstatat64_time64_statx without
any fallback.

It is still wrong to place them in the loongarch arch-syscall.h, it means that
either update-syscall-lists.py has an issue or some bogus kernel headers were
used to generate it.

> 
> clone() is still an open question, this may have to be implemented on top
> of clone3()
> 
>        Arnd