From: Siddhesh Poyarekar <siddhesh@sourceware.org>
To: DJ Delorie <dj@redhat.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH 2/2] Document the M_ARENA_* mallopt parameters
Date: Wed, 26 Oct 2016 05:42:00 -0000 [thread overview]
Message-ID: <c28ab047-ad6a-920c-c08d-a36227725b7e@sourceware.org> (raw)
In-Reply-To: <xnh980qekp.fsf@greed.delorie.com>
On Wednesday 26 October 2016 03:25 AM, DJ Delorie wrote:
> Siddhesh Poyarekar <siddhesh@sourceware.org> writes:
>> -/* Non public mallopt parameters. */
>> #define M_ARENA_TEST -7
>> #define M_ARENA_MAX -8
>
> Hmmm... if these are now public, do they need to be moved elsewhere?
> Like, malloc.h ?
They're already there in malloc.h. I'll push a follow-up patch if they
can be removed.
>> +The presence of multiple @code{arenas} allows multiple threads to allocate
>> +memory simultaneously in their own separate arenas, thus improving performance.
>
> Not quite true - there isn't one arena per thread, there are N arenas
> per M threads. Probably better to say "... simultaneously in separate
> arenas ..."
OK.
>> +environment variable @code{MALLOC_ARENA_TEST} to the desired value.
>> +@item M_ARENA_MAX
>
> Missing blank line.
>
> Otherwise, the content looks OK to me from a technical point of view.
Thanks, I'll fix up formatting comments from Rical and push this.
Siddhesh
next prev parent reply other threads:[~2016-10-26 5:42 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-24 14:08 [PATCH 0/2] Malloc manual cleanups Siddhesh Poyarekar
2016-10-24 14:08 ` [PATCH 2/2] Document the M_ARENA_* mallopt parameters Siddhesh Poyarekar
2016-10-25 7:51 ` Rical Jasan
2016-10-25 21:55 ` DJ Delorie
2016-10-26 5:42 ` Siddhesh Poyarekar [this message]
2016-10-24 14:08 ` [PATCH 1/2] Add note on MALLOC_MMAP_* environment variables Siddhesh Poyarekar
2016-10-26 4:18 ` Carlos O'Donell
2016-10-26 7:58 ` Michael Kerrisk
2016-10-26 9:47 ` Siddhesh Poyarekar
2016-10-26 11:26 ` Rical Jasan
2016-10-26 11:30 ` Siddhesh Poyarekar
2016-10-26 12:04 ` Rical Jasan
-- strict thread matches above, loose matches on Subject: below --
2016-10-10 17:26 Siddhesh Poyarekar
2016-10-10 17:26 ` [PATCH 2/2] Document the M_ARENA_* mallopt parameters Siddhesh Poyarekar
2016-10-17 16:09 ` Carlos O'Donell
2016-10-18 7:15 ` Michael Kerrisk
2016-10-18 10:07 ` Siddhesh Poyarekar
2016-10-18 13:50 ` Michael Kerrisk (man-pages)
2016-10-18 14:30 ` Siddhesh Poyarekar
2016-10-18 16:03 ` Michael Kerrisk (man-pages)
2016-10-18 16:46 ` Siddhesh Poyarekar
2016-10-18 17:18 ` Andreas Schwab
2016-10-19 6:53 ` Michael Kerrisk (man-pages)
2016-10-19 7:09 ` Siddhesh Poyarekar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c28ab047-ad6a-920c-c08d-a36227725b7e@sourceware.org \
--to=siddhesh@sourceware.org \
--cc=dj@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).