* [PATCH] posix: Fix macro expansion producing 'defined' has undefined behavior
@ 2022-08-29 19:00 Adhemerval Zanella
2022-08-29 20:23 ` Paul Eggert
0 siblings, 1 reply; 2+ messages in thread
From: Adhemerval Zanella @ 2022-08-29 19:00 UTC (permalink / raw)
To: libc-alpha
The NEED_CHECK_SPEC is defined as:
#define NEED_CHECK_SPEC \
(!defined _XBS5_ILP32_OFF32 || !defined _XBS5_ILP32_OFFBIG \
|| !defined _XBS5_LP64_OFF64 || !defined _XBS5_LPBIG_OFFBIG \
|| !defined _POSIX_V6_ILP32_OFF32 || !defined _POSIX_V6_ILP32_OFFBIG \
|| !defined _POSIX_V6_LP64_OFF64 || !defined _POSIX_V6_LPBIG_OFFBIG \
|| !defined _POSIX_V7_ILP32_OFF32 || !defined _POSIX_V7_ILP32_OFFBIG \
|| !defined _POSIX_V7_LP64_OFF64 || !defined _POSIX_V7_LPBIG_OFFBIG)
Which is undefined behavior accordingly to C Standard (Preprocessing
directives, p4).
Checked on x86_64-linux-gnu.
---
sysdeps/posix/sysconf.c | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/sysdeps/posix/sysconf.c b/sysdeps/posix/sysconf.c
index f760bf4e2b..c29b70ad80 100644
--- a/sysdeps/posix/sysconf.c
+++ b/sysdeps/posix/sysconf.c
@@ -37,13 +37,17 @@
#define NEED_SPEC_ARRAY 0
#include <posix-conf-vars.h>
-#define NEED_CHECK_SPEC \
- (!defined _XBS5_ILP32_OFF32 || !defined _XBS5_ILP32_OFFBIG \
+#if !defined _XBS5_ILP32_OFF32 || !defined _XBS5_ILP32_OFFBIG \
|| !defined _XBS5_LP64_OFF64 || !defined _XBS5_LPBIG_OFFBIG \
|| !defined _POSIX_V6_ILP32_OFF32 || !defined _POSIX_V6_ILP32_OFFBIG \
|| !defined _POSIX_V6_LP64_OFF64 || !defined _POSIX_V6_LPBIG_OFFBIG \
|| !defined _POSIX_V7_ILP32_OFF32 || !defined _POSIX_V7_ILP32_OFFBIG \
- || !defined _POSIX_V7_LP64_OFF64 || !defined _POSIX_V7_LPBIG_OFFBIG)
+ || !defined _POSIX_V7_LP64_OFF64 || !defined _POSIX_V7_LPBIG_OFFBIG
+# define NEED_CHECK_SPEC 1
+#else
+# define NEED_CHECK_SPEC 0
+#endif
+
#if NEED_CHECK_SPEC
static long int __sysconf_check_spec (const char *spec);
#endif
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] posix: Fix macro expansion producing 'defined' has undefined behavior
2022-08-29 19:00 [PATCH] posix: Fix macro expansion producing 'defined' has undefined behavior Adhemerval Zanella
@ 2022-08-29 20:23 ` Paul Eggert
0 siblings, 0 replies; 2+ messages in thread
From: Paul Eggert @ 2022-08-29 20:23 UTC (permalink / raw)
To: Adhemerval Zanella, libc-alpha
Thank you, this looks good.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-29 20:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-29 19:00 [PATCH] posix: Fix macro expansion producing 'defined' has undefined behavior Adhemerval Zanella
2022-08-29 20:23 ` Paul Eggert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).