public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: libc-alpha@sourceware.org
Subject: Re: [PATCH] scripts/glibcelf.py: Mark as UNSUPPORTED on Python 3.5 and earlier
Date: Mon, 25 Apr 2022 14:21:10 -0300	[thread overview]
Message-ID: <cb3e9227-85c3-6c95-b4d1-f5387ae0d001@linaro.org> (raw)
In-Reply-To: <87fsm1r5ry.fsf@oldenburg.str.redhat.com>



On 25/04/2022 04:17, Florian Weimer via Libc-alpha wrote:
> * Florian Weimer:
> 
>> enum.IntFlag and enum.EnumMeta._missing_ support is not present in those
>> Python versions.
>>
>> ---
>>  scripts/glibcelf.py | 6 ++++++
>>  1 file changed, 6 insertions(+)
>>
>> diff --git a/scripts/glibcelf.py b/scripts/glibcelf.py
>> index 8f7d0ca184..da0d5380f3 100644
>> --- a/scripts/glibcelf.py
>> +++ b/scripts/glibcelf.py
>> @@ -28,6 +28,12 @@ import collections
>>  import enum
>>  import struct
>>  
>> +if not hasattr(enum, 'IntFlag'):
>> +    import sys
>> +    sys.stdout.write(
>> +        'warning: glibcelf.py needs Python 3.6 for enum support\n')
>> +    sys.exit(77)
>> +
>>  class _OpenIntEnum(enum.IntEnum):
>>      """Integer enumeration that supports arbitrary int values."""
>>      @classmethod
> 
> I've pushed this, to avoid masking other failures in Joseph's tester.

We still indicate that Python 3.4 is supported on INSTALL. I think we
should either update it or add a fallback code on glibcelf.py.

  reply	other threads:[~2022-04-25 17:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-22 17:36 Florian Weimer
2022-04-25  7:17 ` Florian Weimer
2022-04-25 17:21   ` Adhemerval Zanella [this message]
2022-04-25 21:06     ` Florian Weimer
2022-04-26 13:19       ` Adhemerval Zanella
2022-04-27 20:45         ` Fangrui Song

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cb3e9227-85c3-6c95-b4d1-f5387ae0d001@linaro.org \
    --to=adhemerval.zanella@linaro.org \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).