public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: libc-alpha@sourceware.org
Subject: Re: time64 / Large File Support: 2) default time64 breaks legacy 32bit binaries
Date: Fri, 27 Jan 2023 14:40:14 -0300	[thread overview]
Message-ID: <cbda6e4b-28e7-1396-d325-eda6e4943cd2@linaro.org> (raw)
In-Reply-To: <aaa0cf5d-e6ca-627d-5450-4da0d2a2b27c@cs.ucla.edu>



On 26/01/23 23:38, Paul Eggert wrote:
> On 1/26/23 05:21, Adhemerval Zanella Netto via Libc-alpha wrote:
>> So although I am not quite against --enable-hard-sys-types64, I personally
>> think we should do something more drastically (which not all other glibc
>> developers agree) and flip the switch to enable 64-bit time_t *as default*
>> and document 32-bit is opt-in.
> 
> Just to clarify, there are two issues here:
> 
> A. Should _FILE_OFFSET_BITS and _TIME_BITS default to 64 instead of to 32?

That is my understanding to make 64-bit time_t the default ABI.

> 
> B. Should _FILE_OFFSET_BITS=64 and _TIME_BITS=64 be the *only* values supported? That is, should the old API (with 32-bit time_t, off_t, etc.) be available only to old 32-bit executables, and not to newly-built 32-bit executables?

That's a good question and I think it does make sense to move the non-LFS
and 32-bit time_t API to compat code and only provide 64-bif off_t/time_t 
support.

> 
> As I understood it, the proposal was that (A) and (B) both default to "no", but '.../configure --enable-hard-sys-types64' would change both (A) and (B) to "yes".
> 
> It sounds like you're proposing a more drastic approach, in which (A) and (B) both default to "yes", but '.../configure --disable-hard-sys-types64' changes them both to "no". Is that right?

Not really, my proposal was initial to set (A) to 'yes' but still allow new
programs to be built with -D_FILE_OFFSET_BITS=32 and -D_TIME_BITS=32.  But
making the later compat symbols seems also a good thing to cement for good
the old interfaces.

I am really trying to avoid a configure switch (such as --disable-hard-sys-types64),
they tend to be become rotten and fail due lack of testing (and also add some
fragmentation due each distro using different switch).

> 
> Another possibility is to adopt the milder approach for glibc version N, and switch to the more drastic approach in glibc version N+1.This would give distros time to test this new configure-time option before it's the default.
Do you mean add the --enable-hard-sys-types64 on glibc N, and then remove it on
N+1 and make the 64-bit the default? 

  reply	other threads:[~2023-01-27 17:40 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-25 23:57 The time64 and Large File Support mess Andreas K. Huettel
2023-01-25 23:58 ` time64 / Large File Support: 1) [2.28 Regression]: New getdents{64} implementation breaks qemu-user Andreas K. Huettel
2023-01-26 12:21   ` Adhemerval Zanella Netto
2023-01-27 20:08     ` Andreas K. Huettel
2023-01-25 23:59 ` time64 / Large File Support: 2) default time64 breaks legacy 32bit binaries Andreas K. Huettel
2023-01-26  4:13   ` Paul Eggert
2023-01-26 13:21     ` Adhemerval Zanella Netto
2023-01-26 23:35       ` Sam James
2023-01-27 17:33         ` Adhemerval Zanella Netto
2023-02-01 16:26         ` Florian Weimer
2023-02-01 19:47           ` Sam James
2023-02-01 19:54             ` Sam James
2023-02-03 17:52             ` Florian Weimer
2023-02-01 22:22           ` Michael Hudson-Doyle
2023-02-03 14:17             ` Adhemerval Zanella Netto
2023-02-03 18:56               ` Florian Weimer
2023-01-27  2:38       ` Paul Eggert
2023-01-27 17:40         ` Adhemerval Zanella Netto [this message]
2023-01-27 23:51           ` Paul Eggert
2023-01-27 23:58             ` Joseph Myers
2023-02-01 12:27               ` Adhemerval Zanella Netto
2023-01-26 10:43   ` Florian Weimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cbda6e4b-28e7-1396-d325-eda6e4943cd2@linaro.org \
    --to=adhemerval.zanella@linaro.org \
    --cc=eggert@cs.ucla.edu \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).