From: Jiangfeng Xiao <xiaojiangfeng@huawei.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>,
<libc-alpha@sourceware.org>, <schwab@linux-m68k.org>,
<nixiaoming@huawei.com>, <douzhaolei@huawei.com>,
<wangbing6@huawei.com>, <wangfangpeng1@huawei.com>
Subject: Re: [PATCH] elf: sanitize objname in _dl_signal_error
Date: Tue, 2 Apr 2024 23:06:28 +0800 [thread overview]
Message-ID: <ccea1cb6-fff7-d588-0184-a68e018ce9d6@huawei.com> (raw)
In-Reply-To: <CAMe9rOpCixZVLo6i4wx0BTqmDD3TUu-Vb-+qz__D+SbUA_ndUg@mail.gmail.com>
On 2024/4/2 23:00, H.J. Lu wrote:
>>>
>>
>> Maybe. However, the glibc code may reference null pointers,
>> which should be fixed.
>
> Not if a null pointer should never happen.
>
If the fatal_error(0, NULL, NULL, NULL, "invalid mode parameter")
code in the _dl_signal_error function will never be executed,
delete the redundant code. If it is possible, even if the
possibility is very low, it should be fixed.
next prev parent reply other threads:[~2024-04-02 15:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-30 13:40 [PATCH] elf: handle NULL input to fatal_error Jiangfeng Xiao
2024-03-30 15:47 ` Andreas Schwab
2024-04-01 1:40 ` Jiangfeng Xiao
2024-04-01 2:45 ` [PATCH] elf: sanitize objname in _dl_signal_error Jiangfeng Xiao
2024-04-01 13:50 ` Adhemerval Zanella Netto
2024-04-02 14:37 ` Jiangfeng Xiao
2024-04-02 14:42 ` H.J. Lu
2024-04-02 14:54 ` Jiangfeng Xiao
2024-04-02 15:00 ` H.J. Lu
2024-04-02 15:06 ` Jiangfeng Xiao [this message]
2024-04-02 15:08 ` H.J. Lu
2024-04-02 15:21 ` Jiangfeng Xiao
2024-04-02 15:50 ` Adhemerval Zanella Netto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ccea1cb6-fff7-d588-0184-a68e018ce9d6@huawei.com \
--to=xiaojiangfeng@huawei.com \
--cc=adhemerval.zanella@linaro.org \
--cc=douzhaolei@huawei.com \
--cc=hjl.tools@gmail.com \
--cc=libc-alpha@sourceware.org \
--cc=nixiaoming@huawei.com \
--cc=schwab@linux-m68k.org \
--cc=wangbing6@huawei.com \
--cc=wangfangpeng1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).