* [PATCH] Fix elf/tst-tls9-static after libdl cleanups.
@ 2021-06-09 11:19 Stefan Liebler
2021-06-09 11:24 ` Florian Weimer
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Liebler @ 2021-06-09 11:19 UTC (permalink / raw)
To: libc-alpha; +Cc: fweimer, Stefan Liebler
The testcase elf/tst-tls9-static sometimes fails with:
cannot open 'tst-tlsmod5.so': tst-tlsmod5.so: cannot open shared object file: No such file or directory
cannot open 'tst-tlsmod6.so': tst-tlsmod6.so: cannot open shared object file: No such file or directory
After recent commit
6f1c701026287f6928d3bdd1aea7359308635abe
"dlfcn: Cleanups after -ldl is no longer required"
the libdl variable is not set anymore and thus the
dependencies were missing.
---
elf/Makefile | 2 --
1 file changed, 2 deletions(-)
diff --git a/elf/Makefile b/elf/Makefile
index e9788d3d4f..6dbb03bbb2 100644
--- a/elf/Makefile
+++ b/elf/Makefile
@@ -1050,10 +1050,8 @@ unload7-ENV = MALLOC_PERTURB_=85
$(objpfx)unload8.out: $(objpfx)unload8mod1.so $(objpfx)unload8mod1x.so
-ifdef libdl
$(objpfx)tst-tls9-static: $(common-objpfx)dlfcn/libdl.a
$(objpfx)tst-tls9-static.out: $(objpfx)tst-tlsmod5.so $(objpfx)tst-tlsmod6.so
-endif
ifeq ($(have-z-execstack),yes)
$(objpfx)tst-execstack.out: $(objpfx)tst-execstack-mod.so
--
2.30.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix elf/tst-tls9-static after libdl cleanups.
2021-06-09 11:19 [PATCH] Fix elf/tst-tls9-static after libdl cleanups Stefan Liebler
@ 2021-06-09 11:24 ` Florian Weimer
2021-06-09 11:40 ` Stefan Liebler
0 siblings, 1 reply; 3+ messages in thread
From: Florian Weimer @ 2021-06-09 11:24 UTC (permalink / raw)
To: Stefan Liebler; +Cc: libc-alpha
* Stefan Liebler:
> The testcase elf/tst-tls9-static sometimes fails with:
> cannot open 'tst-tlsmod5.so': tst-tlsmod5.so: cannot open shared object file: No such file or directory
> cannot open 'tst-tlsmod6.so': tst-tlsmod6.so: cannot open shared object file: No such file or directory
>
> After recent commit
> 6f1c701026287f6928d3bdd1aea7359308635abe
> "dlfcn: Cleanups after -ldl is no longer required"
> the libdl variable is not set anymore and thus the
> dependencies were missing.
> ---
> elf/Makefile | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/elf/Makefile b/elf/Makefile
> index e9788d3d4f..6dbb03bbb2 100644
> --- a/elf/Makefile
> +++ b/elf/Makefile
> @@ -1050,10 +1050,8 @@ unload7-ENV = MALLOC_PERTURB_=85
>
> $(objpfx)unload8.out: $(objpfx)unload8mod1.so $(objpfx)unload8mod1x.so
>
> -ifdef libdl
> $(objpfx)tst-tls9-static: $(common-objpfx)dlfcn/libdl.a
> $(objpfx)tst-tls9-static.out: $(objpfx)tst-tlsmod5.so $(objpfx)tst-tlsmod6.so
> -endif
Sorry about that. Patch looks fine.
That libdl.a reference is stale; I'll see if I can post a patch to
remove all them in one go.
Thanks,
Florian
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix elf/tst-tls9-static after libdl cleanups.
2021-06-09 11:24 ` Florian Weimer
@ 2021-06-09 11:40 ` Stefan Liebler
0 siblings, 0 replies; 3+ messages in thread
From: Stefan Liebler @ 2021-06-09 11:40 UTC (permalink / raw)
To: Florian Weimer; +Cc: libc-alpha
On 09/06/2021 13:24, Florian Weimer wrote:
> * Stefan Liebler:
>
>> The testcase elf/tst-tls9-static sometimes fails with:
>> cannot open 'tst-tlsmod5.so': tst-tlsmod5.so: cannot open shared object file: No such file or directory
>> cannot open 'tst-tlsmod6.so': tst-tlsmod6.so: cannot open shared object file: No such file or directory
>>
>> After recent commit
>> 6f1c701026287f6928d3bdd1aea7359308635abe
>> "dlfcn: Cleanups after -ldl is no longer required"
>> the libdl variable is not set anymore and thus the
>> dependencies were missing.
>> ---
>> elf/Makefile | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/elf/Makefile b/elf/Makefile
>> index e9788d3d4f..6dbb03bbb2 100644
>> --- a/elf/Makefile
>> +++ b/elf/Makefile
>> @@ -1050,10 +1050,8 @@ unload7-ENV = MALLOC_PERTURB_=85
>>
>> $(objpfx)unload8.out: $(objpfx)unload8mod1.so $(objpfx)unload8mod1x.so
>>
>> -ifdef libdl
>> $(objpfx)tst-tls9-static: $(common-objpfx)dlfcn/libdl.a
>> $(objpfx)tst-tls9-static.out: $(objpfx)tst-tlsmod5.so $(objpfx)tst-tlsmod6.so
>> -endif
>
> Sorry about that. Patch looks fine.
>
> That libdl.a reference is stale; I'll see if I can post a patch to
> remove all them in one go.
>
> Thanks,
> Florian
>
Okay. I've just pushed the patch.
Please remove all those libdl.a references in one go.
Thanks,
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-09 11:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-09 11:19 [PATCH] Fix elf/tst-tls9-static after libdl cleanups Stefan Liebler
2021-06-09 11:24 ` Florian Weimer
2021-06-09 11:40 ` Stefan Liebler
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).