* aio.h fix typos in comments
@ 2020-10-05 21:15 Jonny Grant
2020-10-06 13:12 ` Florian Weimer
0 siblings, 1 reply; 4+ messages in thread
From: Jonny Grant @ 2020-10-05 21:15 UTC (permalink / raw)
To: libc-alpha
[-- Attachment #1: Type: text/plain, Size: 325 bytes --]
Hello
Would a patch be supported to fix these comments? I can go through the formal patch process if you would like me to.
Also fix the spelling mistake "desriptor" twice
, and "simultanious"
Also I removed "This implementation follows the one in Irix. "
Don't think it is relevant, at least now it isn't.
Thanks
Jonny
[-- Attachment #2: aio.h_patch_typos --]
[-- Type: text/plain, Size: 1314 bytes --]
--- aio.h.orig 2020-10-05 21:46:23.354543383 +0100
+++ aio.h_fix_typos 2020-10-05 22:11:30.415180225 +0100
@@ -33,7 +33,7 @@
/* Asynchronous I/O control block. */
struct aiocb
{
- int aio_fildes; /* File desriptor. */
+ int aio_fildes; /* File descriptor. */
int aio_lio_opcode; /* Operation to be performed. */
int aio_reqprio; /* Request priority offset. */
volatile void *aio_buf; /* Location of buffer. */
@@ -61,7 +61,7 @@
#ifdef __USE_LARGEFILE64
struct aiocb64
{
- int aio_fildes; /* File desriptor. */
+ int aio_fildes; /* File descriptor. */
int aio_lio_opcode; /* Operation to be performed. */
int aio_reqprio; /* Request priority offset. */
volatile void *aio_buf; /* Location of buffer. */
@@ -82,12 +82,11 @@
#ifdef __USE_GNU
-/* To customize the implementation one can use the following struct.
- This implementation follows the one in Irix. */
+/* To customize the implementation one can use the following struct. */
struct aioinit
{
int aio_threads; /* Maximal number of threads. */
- int aio_num; /* Number of expected simultanious requests. */
+ int aio_num; /* Number of expected simultaneous requests. */
int aio_locks; /* Not used. */
int aio_usedba; /* Not used. */
int aio_debug; /* Not used. */
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: aio.h fix typos in comments
2020-10-05 21:15 aio.h fix typos in comments Jonny Grant
@ 2020-10-06 13:12 ` Florian Weimer
2020-10-13 20:57 ` Jonny Grant
0 siblings, 1 reply; 4+ messages in thread
From: Florian Weimer @ 2020-10-06 13:12 UTC (permalink / raw)
To: Jonny Grant; +Cc: libc-alpha
* Jonny Grant:
> - int aio_num; /* Number of expected simultanious requests. */
> + int aio_num; /* Number of expected simultaneous requests. */
Please also add the missing space, the line should end with: . */
Commit subject should be something like
rt: Fix typos in comments in <aio.h>
I can push this for you with those changes.
Thanks,
Florian
--
Red Hat GmbH, https://de.redhat.com/ , Registered seat: Grasbrunn,
Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'Neill
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: aio.h fix typos in comments
2020-10-06 13:12 ` Florian Weimer
@ 2020-10-13 20:57 ` Jonny Grant
2020-10-19 9:09 ` Florian Weimer
0 siblings, 1 reply; 4+ messages in thread
From: Jonny Grant @ 2020-10-13 20:57 UTC (permalink / raw)
To: Florian Weimer; +Cc: libc-alpha
On 06/10/2020 14:12, Florian Weimer wrote:
> * Jonny Grant:
>
>> - int aio_num; /* Number of expected simultanious requests. */
>> + int aio_num; /* Number of expected simultaneous requests. */
>
> Please also add the missing space, the line should end with: . */
>
> Commit subject should be something like
>
> rt: Fix typos in comments in <aio.h>
>
> I can push this for you with those changes.
>
> Thanks,
> Florian
>
Hello Florian
Just wanted to check my other email with aio.h patch came through ok?
In addition, I emailed some patches for alloca.h, alliases.h sys/cdefs.h
Thank you
Jonny
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: aio.h fix typos in comments
2020-10-13 20:57 ` Jonny Grant
@ 2020-10-19 9:09 ` Florian Weimer
0 siblings, 0 replies; 4+ messages in thread
From: Florian Weimer @ 2020-10-19 9:09 UTC (permalink / raw)
To: Jonny Grant; +Cc: libc-alpha
* Jonny Grant:
> Just wanted to check my other email with aio.h patch came through ok?
I have pushed this for you, after fixing up things manually. (The other
patches do not apply cleanly, either.)
Thanks,
Florian
--
Red Hat GmbH, https://de.redhat.com/ , Registered seat: Grasbrunn,
Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'Neill
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-10-19 9:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-05 21:15 aio.h fix typos in comments Jonny Grant
2020-10-06 13:12 ` Florian Weimer
2020-10-13 20:57 ` Jonny Grant
2020-10-19 9:09 ` Florian Weimer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).