From: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
To: Noah Goldstein <goldstein.w.n@gmail.com>
Cc: GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH] elf: Remove -fno-tree-loop-distribute-patterns usage on dl-support
Date: Wed, 10 Aug 2022 10:04:06 -0300 [thread overview]
Message-ID: <da50d728-30e8-13da-d3e2-e6be200154df@linaro.org> (raw)
In-Reply-To: <CAFUsyf+WQFcd=bjt_+jnh81YAb6w58YkXuWKUR8QwGaqyqag=Q@mail.gmail.com>
On 10/08/22 00:37, Noah Goldstein wrote:
>> #endif
>> diff --git a/sysdeps/x86_64/multiarch/memset-evex-unaligned-erms.S b/sysdeps/x86_64/multiarch/memset-evex-unaligned-erms.S
>> index ac4b2d2d50..034d19b35e 100644
>> --- a/sysdeps/x86_64/multiarch/memset-evex-unaligned-erms.S
>> +++ b/sysdeps/x86_64/multiarch/memset-evex-unaligned-erms.S
>> @@ -44,4 +44,7 @@
>>
>> # define USE_LESS_VEC_MASK_STORE 1
>> # include "memset-vec-unaligned-erms.S"
>> +# if !defined NO_MULTIARCH && MINIMUM_X86_ISA_LEVEL >= 4
>> +strong_alias (__memset_evex_unaligned, __memset_generic)
>> +# endif
>
> Instead of adding aliases in each file can't you just add one alias
> at the end of multiarch/rtld-memset.S?
>
> Might be cleaner. Generally prefer keeping all the alias stuff
> out of the implementation files if possible.
The problem is not really the loader since we do not support calling ifunc
from it (that's why multiple ports have rtld-* overrides), the issue is the
initialization for static where either functions call are not possible
(dl-tunables.c) or ifunc calls are not possible (dl-support.c).
In any case, I am experiment with H.J. suggestion to alias to a per-arch
symbol instead of add a generic one.
prev parent reply other threads:[~2022-08-10 13:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-08 20:00 Adhemerval Zanella
2022-08-08 22:16 ` H.J. Lu
2022-08-09 12:11 ` Adhemerval Zanella Netto
2022-08-09 18:31 ` H.J. Lu
2022-08-09 18:48 ` Adhemerval Zanella Netto
2022-08-09 19:06 ` H.J. Lu
2022-08-09 19:32 ` Adhemerval Zanella Netto
2022-08-09 19:34 ` H.J. Lu
2022-08-09 19:40 ` Adhemerval Zanella Netto
2022-08-09 21:51 ` H.J. Lu
2022-08-10 13:12 ` Adhemerval Zanella Netto
2022-08-10 3:37 ` Noah Goldstein
2022-08-10 13:04 ` Adhemerval Zanella Netto [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da50d728-30e8-13da-d3e2-e6be200154df@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=goldstein.w.n@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).