From: Carlos O'Donell <carlos@redhat.com>
To: Joseph Myers <joseph@codesourcery.com>,
Paul Pluzhnikov <ppluzhnikov@google.com>
Cc: Andreas Schwab <schwab@linux-m68k.org>,
Paul Pluzhnikov via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [committed][PATCH] Use __builtin_FILE instead of __FILE__ in assert in C++.
Date: Mon, 13 Feb 2023 09:23:05 -0500 [thread overview]
Message-ID: <da80e0a3-1d8e-f07e-9562-7efb40b09a06@redhat.com> (raw)
In-Reply-To: <9030e0a4-4178-6d0-efee-dd736137cab4@codesourcery.com>
On 2/10/23 16:56, Joseph Myers wrote:
> On Fri, 10 Feb 2023, Paul Pluzhnikov via Libc-alpha wrote:
>
>> I was able to push amended patch (since there were no newer commits).
>> Is that what I should have done?
>
> No, you should never do non-fast-forward pushes to master or other shared
> branches. Carlos, could you investigate why the allow-non-fast-forward =
> (?!master|release.*) setting wasn't working to prevent such a push? Is
> the setting being matched against full ref names and so considering
> refs/heads/master to match (?!master|release.*)?
>
Yes, I'll look at this. This shouldn't be allowed.
--
Cheers,
Carlos.
prev parent reply other threads:[~2023-02-13 14:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-10 16:26 Paul Pluzhnikov
2023-02-10 17:01 ` Andreas Schwab
2023-02-10 17:15 ` Paul Pluzhnikov
2023-02-10 21:56 ` Joseph Myers
2023-02-13 14:23 ` Carlos O'Donell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da80e0a3-1d8e-f07e-9562-7efb40b09a06@redhat.com \
--to=carlos@redhat.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=ppluzhnikov@google.com \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).