public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@palves.net>
To: Simon Marchi <simon.marchi@polymtl.ca>,
	Florian Weimer <fweimer@redhat.com>
Cc: libc-alpha@sourceware.org, gdb-patches@sourceware.org,
	Emil Velikov <emil.l.velikov@gmail.com>,
	Kevin Buettner <kevinb@redhat.com>
Subject: Re: [PATCH glibc] nptl_db: different libpthread/ld.so load orders (bug 27744)
Date: Fri, 16 Apr 2021 18:18:24 +0100	[thread overview]
Message-ID: <daf02031-c30e-7bf9-c5a8-047c497406b1@palves.net> (raw)
In-Reply-To: <83364527-b4aa-b7cc-928b-10d20c4338a3@polymtl.ca>

On 16/04/21 17:53, Simon Marchi wrote:

> Do we need / want to fix GDB if this goes in glibc then?  

I think so.  We may need to discuss more the "needs_setup" hack, but we
can do that in that thread.

Given that libpthread.so is going away in the future, we should be thinking about
addressing that as well.  Does your patch fix that as side effect?

If not, GDB should be keying the loading of libthread_db.so on something else.
Making GDB try to load libthread_db in reaction to processing ld.so instead
libthread_db.so would fix that, I think.  And, it would fix this ordering problem at
hand as well.  So if we do that, maybe we don't need the other changes.

> I have an
> updated version of my patch here [1] sitting here, that makes it work
> with GDBserver as well, with the "broken" glibc 2.33.  I'm wondering if
> I should post it or not.

> 
> Even without this bug, my patch can be beneficial from an efficiency
> point of view, since it delays sending a qSymbol to the remote side
> until all shared libraries are known.  

Right, I like batching for this reason.

> But then it would be a completely
> different rationale, I would have to word the commit message in terms of
> "make things more efficient" rather than "fix a bug while attaching".
> 

  reply	other threads:[~2021-04-16 17:18 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-16 15:56 Florian Weimer
2021-04-16 16:07 ` Simon Marchi
2021-04-16 16:12   ` Florian Weimer
2021-04-16 16:25   ` Pedro Alves
2021-04-16 16:28     ` Florian Weimer
2021-04-16 16:33       ` Pedro Alves
2021-04-16 16:43         ` Florian Weimer
2021-04-16 16:47           ` Pedro Alves
2021-04-16 16:53             ` Simon Marchi
2021-04-16 17:18               ` Pedro Alves [this message]
2021-04-16 17:26                 ` Florian Weimer
2021-04-16 17:33                 ` Simon Marchi
2021-04-16 18:29                   ` Pedro Alves
2021-04-16 18:35                   ` Florian Weimer
2021-04-16 17:28             ` Florian Weimer
2021-04-16 17:43               ` Pedro Alves
2021-04-19  9:06                 ` Florian Weimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=daf02031-c30e-7bf9-c5a8-047c497406b1@palves.net \
    --to=pedro@palves.net \
    --cc=emil.l.velikov@gmail.com \
    --cc=fweimer@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=kevinb@redhat.com \
    --cc=libc-alpha@sourceware.org \
    --cc=simon.marchi@polymtl.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).