public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] fix: Always export ntp_gettimex function
@ 2021-03-23 10:58 Lukasz Majewski
  2021-03-23 11:12 ` Andreas Schwab
  0 siblings, 1 reply; 4+ messages in thread
From: Lukasz Majewski @ 2021-03-23 10:58 UTC (permalink / raw)
  To: Joseph Myers, Adhemerval Zanella
  Cc: Paul Eggert, Arnd Bergmann, GNU C Library, Florian Weimer,
	Carlos O'Donell, Lukasz Majewski

After this patch applied the ntp_gettimex function is always exported
in the sys/timex.h header. Currently it is not when __REDIRECT_NTH is
defined (i.e. in ARM 32 bit port).
---
 sysdeps/unix/sysv/linux/sys/timex.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sysdeps/unix/sysv/linux/sys/timex.h b/sysdeps/unix/sysv/linux/sys/timex.h
index 37931ff496..eb8d15a806 100644
--- a/sysdeps/unix/sysv/linux/sys/timex.h
+++ b/sysdeps/unix/sysv/linux/sys/timex.h
@@ -56,12 +56,12 @@ __BEGIN_DECLS
 
 extern int __adjtimex (struct timex *__ntx) __THROW;
 extern int adjtimex (struct timex *__ntx) __THROW;
+extern int ntp_gettimex (struct ntptimeval *__ntv) __THROW;
 
 #ifdef __REDIRECT_NTH
 extern int __REDIRECT_NTH (ntp_gettime, (struct ntptimeval *__ntv),
 			   ntp_gettimex);
 #else
-extern int ntp_gettimex (struct ntptimeval *__ntv) __THROW;
 # define ntp_gettime ntp_gettimex
 #endif
 extern int ntp_adjtime (struct timex *__tntx) __THROW;
-- 
2.20.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] fix: Always export ntp_gettimex function
  2021-03-23 10:58 [PATCH] fix: Always export ntp_gettimex function Lukasz Majewski
@ 2021-03-23 11:12 ` Andreas Schwab
  2021-03-23 11:24   ` Lukasz Majewski
  0 siblings, 1 reply; 4+ messages in thread
From: Andreas Schwab @ 2021-03-23 11:12 UTC (permalink / raw)
  To: Lukasz Majewski
  Cc: Joseph Myers, Adhemerval Zanella, Florian Weimer, GNU C Library

On Mär 23 2021, Lukasz Majewski wrote:

> After this patch applied the ntp_gettimex function is always exported

s/exported/declared/

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] fix: Always export ntp_gettimex function
  2021-03-23 11:12 ` Andreas Schwab
@ 2021-03-23 11:24   ` Lukasz Majewski
  2021-03-23 13:22     ` Adhemerval Zanella
  0 siblings, 1 reply; 4+ messages in thread
From: Lukasz Majewski @ 2021-03-23 11:24 UTC (permalink / raw)
  To: Andreas Schwab
  Cc: Joseph Myers, Adhemerval Zanella, Florian Weimer, GNU C Library

[-- Attachment #1: Type: text/plain, Size: 478 bytes --]

Hi Andreas,

> On Mär 23 2021, Lukasz Majewski wrote:
> 
> > After this patch applied the ntp_gettimex function is always
> > exported  
> 
> s/exported/declared/

Corrected, thanks.

> 
> Andreas.
> 


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] fix: Always export ntp_gettimex function
  2021-03-23 11:24   ` Lukasz Majewski
@ 2021-03-23 13:22     ` Adhemerval Zanella
  0 siblings, 0 replies; 4+ messages in thread
From: Adhemerval Zanella @ 2021-03-23 13:22 UTC (permalink / raw)
  To: Lukasz Majewski, Andreas Schwab; +Cc: GNU C Library



On 23/03/2021 08:24, Lukasz Majewski wrote:
> Hi Andreas,
> 
>> On Mär 23 2021, Lukasz Majewski wrote:
>>
>>> After this patch applied the ntp_gettimex function is always
>>> exported
>>
>> s/exported/declared/
> 
> Corrected, thanks.
> 
>>
>> Andreas.
>>
> 
> 
> Best regards,
> 
> Lukasz Majewski
> 

LGTM with Andreas remark fixed.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-03-23 13:22 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-23 10:58 [PATCH] fix: Always export ntp_gettimex function Lukasz Majewski
2021-03-23 11:12 ` Andreas Schwab
2021-03-23 11:24   ` Lukasz Majewski
2021-03-23 13:22     ` Adhemerval Zanella

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).