* [patch committed] Fix build-and-build-again bug in sunrpc tests.
@ 2016-11-14 19:28 Zack Weinberg
0 siblings, 0 replies; only message in thread
From: Zack Weinberg @ 2016-11-14 19:28 UTC (permalink / raw)
To: GNU C Library
rpcgen will error out if the file it's asked to create already exists.
Several other rules in sunrpc/Makefile take care to delete rpcgen-
generated files before creating them, but rpcgen-tests doesn't, which
can lead to spurious test failures in an incremental rebuild.
Tested on x86_64-linux-gnu, committed as obvious.
zw
* sunrpc/Makefile (rpcgen-tests): Delete the .out file before
creating or re-creating it.
diff --git a/sunrpc/Makefile b/sunrpc/Makefile
index 99e5c3c..9e805fb 100644
--- a/sunrpc/Makefile
+++ b/sunrpc/Makefile
@@ -233,6 +233,7 @@ $(objpfx)thrsvc: $(common-objpfx)linkobj/libc.so
$(shared-thread-library)
ifeq ($(run-built-tests),yes)
$(rpcgen-tests): $(objpfx)%.out: %.x $(objpfx)rpcgen
+ -rm -f $@
$(built-program-cmd) -c $< -o $@; \
$(evaluate-test)
endif
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2016-11-14 19:28 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-14 19:28 [patch committed] Fix build-and-build-again bug in sunrpc tests Zack Weinberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).