* [PATCH] malloc: Do not compile mcheck-init.o as libc module
@ 2017-08-31 9:43 Florian Weimer
2017-10-16 18:49 ` Florian Weimer
0 siblings, 1 reply; 2+ messages in thread
From: Florian Weimer @ 2017-08-31 9:43 UTC (permalink / raw)
To: libc-alpha
Otherwise, this will lead to a link failure because the reference
to mcheck is hidden.
2017-08-31 Florian Weimer <fweimer@redhat.com>
* malloc/Makefile (others-extras): Set to mcheck-init.o.
diff --git a/malloc/Makefile b/malloc/Makefile
index 50b487eeb5..52bbce63c0 100644
--- a/malloc/Makefile
+++ b/malloc/Makefile
@@ -99,6 +99,7 @@ LDFLAGS-tst-mallocstate = -rdynamic
# These should be removed by `make clean'.
extra-objs = mcheck-init.o libmcheck.a
+others-extras = mcheck-init.o
# Include the cleanup handler.
aux := set-freeres thread-freeres
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] malloc: Do not compile mcheck-init.o as libc module
2017-08-31 9:43 [PATCH] malloc: Do not compile mcheck-init.o as libc module Florian Weimer
@ 2017-10-16 18:49 ` Florian Weimer
0 siblings, 0 replies; 2+ messages in thread
From: Florian Weimer @ 2017-10-16 18:49 UTC (permalink / raw)
To: libc-alpha
On 08/31/2017 11:42 AM, Florian Weimer wrote:
> Otherwise, this will lead to a link failure because the reference
> to mcheck is hidden.
>
> 2017-08-31 Florian Weimer <fweimer@redhat.com>
>
> * malloc/Makefile (others-extras): Set to mcheck-init.o.
>
> diff --git a/malloc/Makefile b/malloc/Makefile
> index 50b487eeb5..52bbce63c0 100644
> --- a/malloc/Makefile
> +++ b/malloc/Makefile
> @@ -99,6 +99,7 @@ LDFLAGS-tst-mallocstate = -rdynamic
>
> # These should be removed by `make clean'.
> extra-objs = mcheck-init.o libmcheck.a
> +others-extras = mcheck-init.o
>
> # Include the cleanup handler.
> aux := set-freeres thread-freeres
>
I am going to check this in.
Thanks,
Florian
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-16 18:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-31 9:43 [PATCH] malloc: Do not compile mcheck-init.o as libc module Florian Weimer
2017-10-16 18:49 ` Florian Weimer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).