* [PATCH] Update RWF_SUPPORTED for Linux kernel 4.16 [BZ #22947] @ 2018-04-03 16:07 H.J. Lu 2018-04-03 16:16 ` Adhemerval Zanella 0 siblings, 1 reply; 4+ messages in thread From: H.J. Lu @ 2018-04-03 16:07 UTC (permalink / raw) To: GNU C Library Add RWF_APPEND to RWF_SUPPORTED to support Linux kernel 4.16. OK for master? H.J. --- [BZ #22947] * misc/tst-preadvwritev2-common.c (RWF_APPEND): New. (RWF_SUPPORTED): Add RWF_APPEND. --- misc/tst-preadvwritev2-common.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/misc/tst-preadvwritev2-common.c b/misc/tst-preadvwritev2-common.c index 89fd0a3ff5..99d385173b 100644 --- a/misc/tst-preadvwritev2-common.c +++ b/misc/tst-preadvwritev2-common.c @@ -34,7 +34,11 @@ do_test_with_invalid_flags (void) #ifndef RWF_NOWAIT # define RWF_NOWAIT 0 #endif -#define RWF_SUPPORTED (RWF_HIPRI | RWF_DSYNC | RWF_SYNC | RWF_NOWAIT) +#ifndef RWF_APPEND +# define RWF_APPEND 0x10 +#endif +#define RWF_SUPPORTED (RWF_HIPRI | RWF_DSYNC | RWF_SYNC | RWF_NOWAIT \ + | RWF_APPEND) /* Set the next bit from the mask of all supported flags. */ int invalid_flag = RWF_SUPPORTED != 0 ? __builtin_clz (RWF_SUPPORTED) : 2; invalid_flag = 0x1 << ((sizeof (int) * CHAR_BIT) - invalid_flag); -- 2.14.3 ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Update RWF_SUPPORTED for Linux kernel 4.16 [BZ #22947] 2018-04-03 16:07 [PATCH] Update RWF_SUPPORTED for Linux kernel 4.16 [BZ #22947] H.J. Lu @ 2018-04-03 16:16 ` Adhemerval Zanella 2018-04-03 18:18 ` H.J. Lu 0 siblings, 1 reply; 4+ messages in thread From: Adhemerval Zanella @ 2018-04-03 16:16 UTC (permalink / raw) To: libc-alpha On 03/04/2018 13:07, H.J. Lu wrote: > Add RWF_APPEND to RWF_SUPPORTED to support Linux kernel 4.16. > > OK for master? Now 4.16 is out we need to update sysdeps/unix/sysv/linux/bits/uio-ext.h, bits/uio-ext.h, and manual/llio.texi as well. > > H.J. > --- > [BZ #22947] > * misc/tst-preadvwritev2-common.c (RWF_APPEND): New. > (RWF_SUPPORTED): Add RWF_APPEND. > --- > misc/tst-preadvwritev2-common.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/misc/tst-preadvwritev2-common.c b/misc/tst-preadvwritev2-common.c > index 89fd0a3ff5..99d385173b 100644 > --- a/misc/tst-preadvwritev2-common.c > +++ b/misc/tst-preadvwritev2-common.c > @@ -34,7 +34,11 @@ do_test_with_invalid_flags (void) > #ifndef RWF_NOWAIT > # define RWF_NOWAIT 0 > #endif > -#define RWF_SUPPORTED (RWF_HIPRI | RWF_DSYNC | RWF_SYNC | RWF_NOWAIT) > +#ifndef RWF_APPEND > +# define RWF_APPEND 0x10 > +#endif > +#define RWF_SUPPORTED (RWF_HIPRI | RWF_DSYNC | RWF_SYNC | RWF_NOWAIT \ > + | RWF_APPEND) > /* Set the next bit from the mask of all supported flags. */ > int invalid_flag = RWF_SUPPORTED != 0 ? __builtin_clz (RWF_SUPPORTED) : 2; > invalid_flag = 0x1 << ((sizeof (int) * CHAR_BIT) - invalid_flag); > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Update RWF_SUPPORTED for Linux kernel 4.16 [BZ #22947] 2018-04-03 16:16 ` Adhemerval Zanella @ 2018-04-03 18:18 ` H.J. Lu 2018-04-03 19:15 ` Adhemerval Zanella 0 siblings, 1 reply; 4+ messages in thread From: H.J. Lu @ 2018-04-03 18:18 UTC (permalink / raw) To: Adhemerval Zanella; +Cc: GNU C Library [-- Attachment #1: Type: text/plain, Size: 400 bytes --] On Tue, Apr 3, 2018 at 9:15 AM, Adhemerval Zanella <adhemerval.zanella@linaro.org> wrote: > > > On 03/04/2018 13:07, H.J. Lu wrote: >> Add RWF_APPEND to RWF_SUPPORTED to support Linux kernel 4.16. >> >> OK for master? > > Now 4.16 is out we need to update sysdeps/unix/sysv/linux/bits/uio-ext.h, > bits/uio-ext.h, and manual/llio.texi as well. > Here is the updated patch. OK for master? -- H.J. [-- Attachment #2: 0001-Update-RWF_SUPPORTED-for-Linux-kernel-4.16-BZ-22947.patch --] [-- Type: text/x-patch, Size: 3040 bytes --] From c5752a44152a097609c7a2898fdf0c88d5b4a17f Mon Sep 17 00:00:00 2001 From: "H.J. Lu" <hjl.tools@gmail.com> Date: Wed, 14 Mar 2018 09:54:28 -0700 Subject: [PATCH] Update RWF_SUPPORTED for Linux kernel 4.16 [BZ #22947] Add RWF_APPEND to RWF_SUPPORTED to support Linux kernel 4.16. [BZ #22947] * bits/uio-ext.h (RWF_APPEND): New. * sysdeps/unix/sysv/linux/bits/uio-ext.h (RWF_APPEND): Likewise. * manual/llio.texi: Document RWF_APPEND. * misc/tst-preadvwritev2-common.c (RWF_APPEND): New. (RWF_SUPPORTED): Add RWF_APPEND. --- bits/uio-ext.h | 1 + manual/llio.texi | 3 +++ misc/tst-preadvwritev2-common.c | 6 +++++- sysdeps/unix/sysv/linux/bits/uio-ext.h | 1 + 4 files changed, 10 insertions(+), 1 deletion(-) diff --git a/bits/uio-ext.h b/bits/uio-ext.h index 8c15a05d9a..d5aa06fd08 100644 --- a/bits/uio-ext.h +++ b/bits/uio-ext.h @@ -28,5 +28,6 @@ #define RWF_DSYNC 0x00000002 /* per-IO O_DSYNC. */ #define RWF_SYNC 0x00000004 /* per-IO O_SYNC. */ #define RWF_NOWAIT 0x00000008 /* per-IO nonblocking mode. */ +#define RWF_APPEND 0x00000010 /* per-IO O_APPEND. */ #endif /* sys/uio_ext.h */ diff --git a/manual/llio.texi b/manual/llio.texi index b4fd5e1d91..82f03be2be 100644 --- a/manual/llio.texi +++ b/manual/llio.texi @@ -1275,6 +1275,9 @@ Per-IO synchronization as if the file was opened with @code{O_SYNC} flag. @item RWF_NOWAIT Use nonblocking mode for this operation; that is, this call to @code{preadv2} will fail and set @code{errno} to @code{EAGAIN} if the operation would block. + +@item RWF_APPEND +Per-IO synchronization as if the file was opened with @code{O_APPEND} flag. @end vtable When the source file is compiled with @code{_FILE_OFFSET_BITS == 64} the diff --git a/misc/tst-preadvwritev2-common.c b/misc/tst-preadvwritev2-common.c index 89fd0a3ff5..f889a21544 100644 --- a/misc/tst-preadvwritev2-common.c +++ b/misc/tst-preadvwritev2-common.c @@ -34,7 +34,11 @@ do_test_with_invalid_flags (void) #ifndef RWF_NOWAIT # define RWF_NOWAIT 0 #endif -#define RWF_SUPPORTED (RWF_HIPRI | RWF_DSYNC | RWF_SYNC | RWF_NOWAIT) +#ifndef RWF_APPEND +# define RWF_APPEND 0 +#endif +#define RWF_SUPPORTED (RWF_HIPRI | RWF_DSYNC | RWF_SYNC | RWF_NOWAIT \ + | RWF_APPEND) /* Set the next bit from the mask of all supported flags. */ int invalid_flag = RWF_SUPPORTED != 0 ? __builtin_clz (RWF_SUPPORTED) : 2; invalid_flag = 0x1 << ((sizeof (int) * CHAR_BIT) - invalid_flag); diff --git a/sysdeps/unix/sysv/linux/bits/uio-ext.h b/sysdeps/unix/sysv/linux/bits/uio-ext.h index 53663ed1a2..8698bc1200 100644 --- a/sysdeps/unix/sysv/linux/bits/uio-ext.h +++ b/sysdeps/unix/sysv/linux/bits/uio-ext.h @@ -46,6 +46,7 @@ extern ssize_t process_vm_writev (pid_t __pid, const struct iovec *__lvec, #define RWF_DSYNC 0x00000002 /* per-IO O_DSYNC. */ #define RWF_SYNC 0x00000004 /* per-IO O_SYNC. */ #define RWF_NOWAIT 0x00000008 /* per-IO nonblocking mode. */ +#define RWF_APPEND 0x00000010 /* per-IO O_APPEND. */ __END_DECLS -- 2.14.3 ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Update RWF_SUPPORTED for Linux kernel 4.16 [BZ #22947] 2018-04-03 18:18 ` H.J. Lu @ 2018-04-03 19:15 ` Adhemerval Zanella 0 siblings, 0 replies; 4+ messages in thread From: Adhemerval Zanella @ 2018-04-03 19:15 UTC (permalink / raw) To: H.J. Lu; +Cc: GNU C Library On 03/04/2018 15:18, H.J. Lu wrote: > On Tue, Apr 3, 2018 at 9:15 AM, Adhemerval Zanella > <adhemerval.zanella@linaro.org> wrote: >> >> >> On 03/04/2018 13:07, H.J. Lu wrote: >>> Add RWF_APPEND to RWF_SUPPORTED to support Linux kernel 4.16. >>> >>> OK for master? >> >> Now 4.16 is out we need to update sysdeps/unix/sysv/linux/bits/uio-ext.h, >> bits/uio-ext.h, and manual/llio.texi as well. >> > > Here is the updated patch. OK for master? > LGTM, thanks. ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-04-03 19:15 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-04-03 16:07 [PATCH] Update RWF_SUPPORTED for Linux kernel 4.16 [BZ #22947] H.J. Lu 2018-04-03 16:16 ` Adhemerval Zanella 2018-04-03 18:18 ` H.J. Lu 2018-04-03 19:15 ` Adhemerval Zanella
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).