From: Florian Weimer <fweimer@redhat.com>
To: Paul Eggert <eggert@cs.ucla.edu>,
GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH] malloc: Implement heap protector
Date: Thu, 10 Nov 2016 15:39:00 -0000 [thread overview]
Message-ID: <e87a9201-9310-e444-d508-f01864c0ed5b@redhat.com> (raw)
In-Reply-To: <296af8bd-17ab-439e-90d1-bfadf3684c7f@redhat.com>
On 11/08/2016 04:13 PM, Florian Weimer wrote:
> diff --git a/sysdeps/generic/ldsodefs.h b/sysdeps/generic/ldsodefs.h
> index f68fdf4..801ded8 100644
> --- a/sysdeps/generic/ldsodefs.h
> +++ b/sysdeps/generic/ldsodefs.h
> @@ -607,6 +607,10 @@ struct rtld_global_ro
> /* List of auditing interfaces. */
> struct audit_ifaces *_dl_audit;
> unsigned int _dl_naudit;
> +
> + /* malloc protection keys. */
> + uintptr_t _dl_malloc_header_guard;
> + uintptr_t _dl_malloc_footer_guard;
> };
> # define __rtld_global_attribute__
> # if IS_IN (rtld)
This way of carrying information from ld.so to libc.so.6 does not work
in the static dlopen case because rtld_global_ro is only initialized
from the static initializer. The code in security_init is never called,
and so the two cookie values are always 0.
I believe this is a pre-existing bug in static dlopen, but I'll need to
write a test case first.
Florian
next prev parent reply other threads:[~2016-11-10 15:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-28 13:17 Florian Weimer
2016-10-28 15:05 ` Carlos O'Donell
2016-10-28 17:56 ` Paul Eggert
2016-11-08 15:13 ` Florian Weimer
2016-11-08 16:09 ` Andreas Schwab
2016-11-10 15:39 ` Florian Weimer [this message]
2016-10-28 20:45 ` DJ Delorie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e87a9201-9310-e444-d508-f01864c0ed5b@redhat.com \
--to=fweimer@redhat.com \
--cc=eggert@cs.ucla.edu \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).